Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HIGH] Showing the paid invoice in the invoice room #45170

Closed
madmax330 opened this issue Jul 10, 2024 · 21 comments
Closed

[HIGH] Showing the paid invoice in the invoice room #45170

madmax330 opened this issue Jul 10, 2024 · 21 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Reviewing Has a PR in review

Comments

@madmax330
Copy link
Contributor

Part of the Invoicing payments project

Main issue: https://github.com/orgs/Expensify/projects/114
Doc section: https://docs.google.com/document/d/1CF5gw-SJx7ckZCgTJNj1IqBnsRuSxD2Bfd_uB5rRGxk/edit#heading=h.drd9tmsdkoix
Project: https://github.com/orgs/Expensify/projects/114

Feature Description

Once an invoice is paid it should show accordingly in the UI

Manual Test Steps

Create an invoice, pay it and make sure it displays correctly

Automated Tests

@madmax330 madmax330 self-assigned this Jul 10, 2024
@melvin-bot melvin-bot bot added the Monthly KSv2 label Jul 15, 2024
@davidcardoza davidcardoza changed the title Showing the paid invoice in the invoice room [HIGH] Showing the paid invoice in the invoice room Jul 16, 2024
@melvin-bot melvin-bot bot added the Overdue label Aug 15, 2024
@rezkiy37
Copy link
Contributor

Hi, I am Michael (Mykhailo) from Callstack, an expert agency and I can work on this issue.

@rezkiy37
Copy link
Contributor

Actively working on the issue. I've opened a draft PR (#48014).

Screenshot 2024-08-26 at 18 03 01

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Monthly KSv2 Overdue labels Aug 27, 2024
@rezkiy37
Copy link
Contributor

I've opened the PR (#48014) for review 🙂

@danielrvidal danielrvidal moved this from High to Critical in [#whatsnext] #billpay Aug 27, 2024
@danielrvidal
Copy link
Contributor

Awesome, thank you! Please let us know if you need any help!

@rezkiy37
Copy link
Contributor

rezkiy37 commented Sep 3, 2024

Hey!
I will be OOO from 04.09 (afternoon) till 09.09. I will continue to work on this one once I am back.

@c3024
Copy link
Contributor

c3024 commented Sep 16, 2024

I reviewed the related PR #48014. It was deployed to production on 9-Sep. Payment is due today.

@madmax330 Can you please assign a BZ for payment? Thanks!

@madmax330 madmax330 added the Bug Something is broken. Auto assigns a BugZero manager. label Sep 17, 2024
Copy link

melvin-bot bot commented Sep 17, 2024

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Sep 17, 2024
@madmax330
Copy link
Contributor Author

@dylanexpensify 👋🏽 We only need to make the payment for the review here.

@c3024 do you get paid in upwork or expensify?

@c3024
Copy link
Contributor

c3024 commented Sep 17, 2024

Upwork!

@dylanexpensify
Copy link
Contributor

Payment summary:

Contributor+: @c3024 $250 via Upwork!

Please apply/request!

@dylanexpensify
Copy link
Contributor

@c3024 apply here! 🙇‍♂️

@c3024
Copy link
Contributor

c3024 commented Sep 18, 2024

@dylanexpensify Thanks. Applied!

@mitul69
Copy link

mitul69 commented Sep 19, 2024

@dylanexpensify I have applied

Copy link

melvin-bot bot commented Sep 19, 2024

📣 @mitul69! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@mitul69
Copy link

mitul69 commented Sep 19, 2024

📣 @mitul69! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Expensify account email: patelmit69@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/mitulpatel116

@c3024
Copy link
Contributor

c3024 commented Sep 23, 2024

@dylanexpensify, gentle bump on payment for this. Thanks!

@dylanexpensify
Copy link
Contributor

On it - apologies!

Copy link

melvin-bot bot commented Oct 2, 2024

@madmax330, @dylanexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@dylanexpensify
Copy link
Contributor

Offers are waiting for acceptance @Krishna2323 @mitul69

@c3024
Copy link
Contributor

c3024 commented Oct 4, 2024

Accepted @dylanexpensify. Only I need to be paid here for the reviewer role. The PR was handled by an external agency and no payment needs to be made for contributor role to anyone. Thanks!

@dylanexpensify
Copy link
Contributor

nice paid!

@github-project-automation github-project-automation bot moved this from Critical to Done in [#whatsnext] #billpay Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Reviewing Has a PR in review
Projects
Status: Done
Development

No branches or pull requests

6 participants