[$250] [#Wave-Control - Add Sage Intacct] Non-reimbursable options text turns gray when clicked

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.6-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #43776

Action Performed:

1. Navigate to https://staging.new.expensify.com/
2. Log in with the expensifail account
3. Navigate to Workspace settings - More features
4. Enable "Accounting"
5. Navigate to Accounting - Export - Export non-reimbursable expenses as
6. Click on "Credit card transactions"
7. Click on "Vendor bills"
8. Close the RHP
9. Navigate to Accounting - Export - Export non-reimbursable expenses as
10. Click on "Vendor bills"
11. Click on "Credit card transactions"

Expected Result:

The text should stay white

Actual Result:

Non-reimbursable options text turns gray when clicked. Only the first click makes the color change after opening the RHP. Clicking on the other option isn't changing the color

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6538305_1720641292101.Full.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010028a93d94af7536
• Upwork Job ID: 1811401490455645006
• Last Price Increase: 2024-07-11
• Automatic offers:
• allgandalf | Reviewer | 103079311

Issue Owner

Current Issue Owner: @allgandalf

[melvin-bot]

Triggered auto assignment to @blimpich (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@blimpich FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[blimpich]

Very niche and not particularly important, demoting.

[blimpich]

Added to the appropriate project so that the project organizer can triage, but this seems very low-priority to me since its just slightly off text color and in a place where exceedingly few customers will see in the next year.

Unassigning as well. It's in the appropriate project so it should get picked up eventually.

[mountiny]

cc @yuwenmemon if you are handling it as well?

@blimpich its good to always find the project leader as well and ping them here or send a DM so they are aware and it does not slip through the cracks (there is many issues in the waave-control project)

[yuwenmemon]

@war-in Can you have a look at this one?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010028a93d94af7536

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (External)

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[war-in]

@yuwenmemon I'm currently looking 👀 The thing is connected with PressableWithFeedback component.

We use OpacityView there and set dimming when item is pressed. It works correctly on mobile (checked on android) but breaks on web.
What I found is that onPressOut is not triggered just after onPressIn function. That's why the pressed component is dimmed.

Screen.Recording.2024-07-11.at.16.22.10.mov

[hungvu193]

This was caused during our review process of #44739 (#44739 (comment)). Since we already had an issue for this, let's push #44739 forward.
Please assign me to this issue @yuwenmemon

[melvin-bot]

📣 @allgandalf 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[war-in]

I found the root cause of the issue! It was wrong handleMouseUp prop in BaseListItem component.
Fortunately, it's already fixed on main branch 🎉

I think issue can be closed now :)

[hungvu193]

Yes I can confirm that this issue is fixed 🎉. We can close it then 😄

Screen.Recording.2024-07-11.at.23.00.27.mov

[miljakljajic]

Excellent!