-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HIGH] SearchForReports requests are not cancelled when new request is made #45803
Comments
Triggered auto assignment to @mallenexpensify ( |
PR was raised and merged, just adding this issue for posteriority. @rinej is there more to follow up/ clean up in this logic? Is this applied to all the money request flows etc where we are calling the search for reports too? |
Cool cool, I was thinking I had deja-vu looking at the issue description |
Hey, as @rinej is on 🏝️ OOO I'll make sure to have someone from our team to take over this in case there's any other action required here:) |
Hi, I will be responsible for the PR in case something needs to be addressed! |
This is done, no payments due |
Problem
When we search for reports in the chat finder page or in the money request flows, we debouncing the search as users type, but we do not cancel the previous search API requests. There is no reason to wait for those, as we have a newer query to search for.
Solution
Search all the previous requests in the queue when a new search query is added.
@rinej
The text was updated successfully, but these errors were encountered: