Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HIGH] SearchForReports requests are not cancelled when new request is made #45803

Closed
mountiny opened this issue Jul 19, 2024 · 6 comments
Closed
Assignees
Labels
NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@mountiny
Copy link
Contributor

mountiny commented Jul 19, 2024

Problem

When we search for reports in the chat finder page or in the money request flows, we debouncing the search as users type, but we do not cancel the previous search API requests. There is no reason to wait for those, as we have a newer query to search for.

Solution

Search all the previous requests in the queue when a new search query is added.

@rinej

Copy link

melvin-bot bot commented Jul 19, 2024

Triggered auto assignment to @mallenexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jul 19, 2024
@mountiny mountiny added the Reviewing Has a PR in review label Jul 19, 2024
@mountiny
Copy link
Contributor Author

PR was raised and merged, just adding this issue for posteriority.

@rinej is there more to follow up/ clean up in this logic? Is this applied to all the money request flows etc where we are calling the search for reports too?

@roryabraham
Copy link
Contributor

PR was raised and merged, just adding this issue for posteriority.

Cool cool, I was thinking I had deja-vu looking at the issue description

@adhorodyski
Copy link
Contributor

Hey, as @rinej is on 🏝️ OOO I'll make sure to have someone from our team to take over this in case there's any other action required here:)

@kacper-mikolajczak
Copy link
Contributor

kacper-mikolajczak commented Jul 24, 2024

Hi, I will be responsible for the PR in case something needs to be addressed!

@roryabraham
Copy link
Contributor

This is done, no payments due

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
Development

No branches or pull requests

5 participants