-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-08-01] Thread – Join button reappears in header when try to join thread after leave it #45828
Comments
Triggered auto assignment to @CortneyOfstad ( |
Triggered auto assignment to @NikkiWines ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
@bernhardoj @akinwale Seems like this might be related to #45136 maybe we should revert the PR and cover these newly found edge cases |
Confirmed that it comes from #45370 as suggested here by reverting it locally. /cc @dominictb @thesahindia if you can think of a fix. In the meantime I'll prepare a revert CP just in case. |
Going to go ahead with the revert for now. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.11-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-08-01. 🎊 |
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
No payment is needed as this was internal and a C+ was not assigned due to comment here. Closing! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.10-2
Reproducible in staging?: yes
Reproducible in production?: no, new feature
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4747620
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause Internal Team
Slack conversation:
Action Performed:
Expected Result:
Join button disappears, user joined to thread
Actual Result:
Join button reappears, user is not joined to thread
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6547693_1721435111628.Join.1.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @CortneyOfstadThe text was updated successfully, but these errors were encountered: