Task – Members and settings options are present in deleted task RHP, chat isn’t archived

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.10-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4747510
Email or phone of affected tester (no customers): applausetester+jpcategory_1@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log in
3. Open chat with user B
4. Create a task
5. Open task detail and send a message
6. Click on the header and delete the task

Expected Result:

Members and settings options disappears in deleted task RHP. Chat is archived

Actual Result:

Members and settings options are present in deleted task RHP

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6547692_1721435092930.Members_Settings.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

We think that this bug might be related to #vip-vsp

[mountiny]

cc @srikarparsi this seems to be related to some of the closed reports logic, not sure if specifically this PR #45568

[srikarparsi]

Hey! Yup, it's related to those changes but I think it's expected (that you can see the full report details when a task is cancelled). But @puneetlath if you could take a look at this too that would be great. The slack conversation where we talked about using state=MANUALREIMBURSED and status=CLOSED for cancelling tasks is here.

Because of the Closed & Archived changes, we show the full report details for all closed reports now (which I think is good unless I'm missing any edge cases). If we want to change this, then we should modify this check to include isClosedReport.

The other option is, if we want cancelling a task to mimic archiving a task (no longer can comment, can't see the full report details, floats to bottom of LHN, etc.), we could add the isArchived rNVP in Auth.

But I personally think this is expected behavior, let me know what you think @puneetlath. I can also bring it up in slack if you would like.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[mountiny]

Thanks, lets discuss here

[mountiny]

From the thread its clear this is not a blocker but still continuing the debate there

[youssef-lr]

Not overdue

[srikarparsi]

I think we should be good to close this out per this discussion? cc @mountiny @puneetlath

[melvin-bot]

@youssef-lr, @srikarparsi Whoops! This issue is 2 days overdue. Let's get this updated quick!

[srikarparsi]

Closing this out (Discussion)