[$250] Chat – “Hmm... ” page appears briefly when navigate to IOU link while logout

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.10-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4751670
Email or phone of affected tester (no customers): ponikarchuks+920724@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

Precondition: use slow 3G network

1. Go to https://staging.new.expensify.com/
2. Log in with Gmail account
3. Create a IOU in a conversation
4. Navigate to the IOU report (conversation)
5. Copy the URL
6. Log out of the app
7. Navigate to the IOU URL
8. Log in with the same account

Expected Result:

You're redirected to the correct IOU report after login

Actual Result:

“Hmm... it's not here” page appears briefly then IOU report opens

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6549210_1721641707809.Hmm._page_appears_briefly_when_navigate_to_IOU_link_while_logout.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0145c59ed1d52e3830
• Upwork Job ID: 1815367593322000546
• Last Price Increase: 2024-07-22

Issue Owner

Current Issue Owner: @abdulrahuman5196

[melvin-bot]

Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

We think that this bug might be related to #vip-vsp

[mountiny]

This seems to be a minor UX issue not blocking the user from using the app so I have demoted it.

Maybe its related to this navigation change #44531 @Kicu in case you could look

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0145c59ed1d52e3830

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[WojtekBoman]

Hey! I’m Wojtek from Software Mansion, an expert agency, and I’d like to work on this issue.

[WojtekBoman]

I took a look at it and I found the root cause of this issue.
I checked an old commit before merging this PR and this issue still occured. It's connected with changes introduced in this one:

https://github.com/Expensify/App/blob/main/src/pages/home/ReportScreen.tsx#L449-L451

  const shouldShowNotFoundPage = useMemo((): boolean => {
        // Wait until we're sure the app is done loading (needs to be a strict equality check since it's undefined initially)
        if (isLoadingApp !== false) {
            return false;
        }

        // If we just finished loading the app, we still need to try fetching the report. Wait until that's done before
        // showing the Not Found page
        if (finishedLoadingApp) {
            return false;
        }

        if (!wasReportAccessibleRef.current && !firstRenderRef.current && !report.reportID && !isOptimisticDelete && !reportMetadata?.isLoadingInitialReportActions && !userLeavingStatus) {
            return true;
        }

        if (shouldHideReport) {
            return true;
        }
        return !!currentReportIDFormRoute && !ReportUtils.isValidReportIDFromPath(currentReportIDFormRoute);
    }, [isLoadingApp, finishedLoadingApp, report.reportID, isOptimisticDelete, reportMetadata?.isLoadingInitialReportActions, userLeavingStatus, shouldHideReport, currentReportIDFormRoute]);

This check returns true which causes showing the not found page:

        if (!wasReportAccessibleRef.current && !firstRenderRef.current && !report.reportID && !isOptimisticDelete && !reportMetadata?.isLoadingInitialReportActions && !userLeavingStatus) {
            return true;
        }

I'd like to make sure why it works this way. @arosiclair Could you take a look at it?

Screen.Recording.2024-07-23.at.16.35.54.mp4

[arosiclair]

I'd like to make sure why it works this way. @arosiclair Could you take a look at it?

Unfortunately I don't really know what those checks are for I just moved them 😅. From what I can guess, it is checking if report is empty but with many caveats like if the report is being loaded for the first time (reportMetadata?.isLoadingInitialReportActions).

[melvin-bot]

This issue has not been updated in over 15 days. @madmax330, @abdulrahuman5196 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[abdulrahuman5196]

@madmax330 I think we can close this issue.
Reference: #46112 (comment)

This issue should already be resolved, I see that Report Screen has been migrated to use useOnyx in this #45711. If this error no longer appears, I'll close this PR. Could you check if it works for you on the main branch?

And issue is not reproducible anymore.

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[mvtglobally]

Issue not reproducible during KI retests. (Third week)

[mvtglobally]

Issue not reproducible during KI retests. (4th week)

[abdulrahuman5196]

@madmax330 I think we can close this issue

[mallenexpensify]

Thanks for posting in #contributor-plus @abdulrahuman5196 , closing