Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PAID] [CRITICAL] [Advanced Approval Workflows] Implement <WorkspaceWorkflowsApprovalsExpensesFromPage /> for Member Selection #45955

Closed
tgolen opened this issue Jul 22, 2024 · 18 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Task

Comments

@tgolen
Copy link
Contributor

tgolen commented Jul 22, 2024

Coming from: #wave-control: advanced approval + workflows polish

Issue OwnerCurrent Issue Owner: @blazejkustra
@blazejkustra
Copy link
Contributor

Hey! I’m Błażej Kustra from Software Mansion, an expert agency, and I’d like to work on this issue!

Copy link

melvin-bot bot commented Jul 26, 2024

@tgolen, @blazejkustra Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Jul 26, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 Overdue labels Jul 30, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Aug 1, 2024
@melvin-bot melvin-bot bot changed the title [CRITICAL] [Advanced Approval Workflows] Implement <WorkspaceWorkflowsApprovalsExpensesFromPage /> for Member Selection [HOLD for payment 2024-08-09] [CRITICAL] [Advanced Approval Workflows] Implement <WorkspaceWorkflowsApprovalsExpensesFromPage /> for Member Selection Aug 2, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Aug 2, 2024
Copy link

melvin-bot bot commented Aug 2, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Aug 2, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.15-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-08-09. 🎊

For reference, here are some details about the assignees on this issue:

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Aug 7, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-08-09] [CRITICAL] [Advanced Approval Workflows] Implement <WorkspaceWorkflowsApprovalsExpensesFromPage /> for Member Selection [HOLD for payment 2024-08-14] [HOLD for payment 2024-08-09] [CRITICAL] [Advanced Approval Workflows] Implement <WorkspaceWorkflowsApprovalsExpensesFromPage /> for Member Selection Aug 7, 2024
Copy link

melvin-bot bot commented Aug 7, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.17-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-08-14. 🎊

For reference, here are some details about the assignees on this issue:

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Aug 8, 2024
Copy link

melvin-bot bot commented Aug 13, 2024

@tgolen, @blazejkustra Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot added the Overdue label Aug 13, 2024
Copy link

melvin-bot bot commented Aug 14, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

Copy link

melvin-bot bot commented Aug 15, 2024

@tgolen, @blazejkustra 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@suneox
Copy link
Contributor

suneox commented Aug 15, 2024

I’ve reviewed PR #46510, so should we have pending payment for this issue?

@melvin-bot melvin-bot bot removed the Overdue label Aug 16, 2024
@tgolen tgolen added Overdue Bug Something is broken. Auto assigns a BugZero manager. labels Aug 16, 2024
Copy link

melvin-bot bot commented Aug 16, 2024

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@tgolen
Copy link
Contributor Author

tgolen commented Aug 16, 2024

@strepanier03 Could you please assist with paying @suneox for a C+ review of the PR?

@strepanier03
Copy link
Contributor

@suneox, can you please link me to your Upwork profile? For some reason, I can't find you among our hires to send the contract.

@melvin-bot melvin-bot bot added the Overdue label Aug 19, 2024
@strepanier03
Copy link
Contributor

Scratch that, you come up under a different last initial but I found you now, all good.

@strepanier03
Copy link
Contributor

Offer sent, I'll check again in a couple hours to see if I can pay it.

@suneox
Copy link
Contributor

suneox commented Aug 19, 2024

Offer sent, I'll check again in a couple hours to see if I can pay it.

@strepanier03 Thank you, I have accepted an offer

Copy link

melvin-bot bot commented Aug 19, 2024

@tgolen, @strepanier03, @suneox, @blazejkustra Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@strepanier03
Copy link
Contributor

Thanks @suneox, I've paid it and closed the contract.

@melvin-bot melvin-bot bot removed the Overdue label Aug 19, 2024
@strepanier03 strepanier03 changed the title [HOLD for payment 2024-08-14] [HOLD for payment 2024-08-09] [CRITICAL] [Advanced Approval Workflows] Implement <WorkspaceWorkflowsApprovalsExpensesFromPage /> for Member Selection [PAID] [CRITICAL] [Advanced Approval Workflows] Implement <WorkspaceWorkflowsApprovalsExpensesFromPage /> for Member Selection Aug 19, 2024
Copy link

melvin-bot bot commented Aug 27, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Task
Projects
None yet
Development

No branches or pull requests

4 participants