Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-08-09] [Payment card / Subscription] make 3DS modal close when authentication fails #46066

Closed
blimpich opened this issue Jul 23, 2024 · 5 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering

Comments

@blimpich
Copy link
Contributor

blimpich commented Jul 23, 2024

Problem

When a user fails the SCA / 3DS authentication flow the modal doesn't close. This is slightly tricky to test since only expensify engineers can test this due to how the 3DS authentication flow works.

Screen.Recording.2024-07-23.at.12.52.35.PM.mov

Solution

Make the modal close.

@blimpich blimpich self-assigned this Jul 23, 2024
@blimpich blimpich converted this from a draft issue Jul 23, 2024
@blimpich blimpich changed the title [Payment card / Subscription] make 3ds modal close when authentication fails [Payment card / Subscription] make 3DS modal close when authentication fails Jul 23, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jul 23, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Aug 2, 2024
@melvin-bot melvin-bot bot changed the title [Payment card / Subscription] make 3DS modal close when authentication fails [HOLD for payment 2024-08-09] [Payment card / Subscription] make 3DS modal close when authentication fails Aug 2, 2024
Copy link

melvin-bot bot commented Aug 2, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Aug 2, 2024
Copy link

melvin-bot bot commented Aug 2, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.15-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-08-09. 🎊

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Aug 8, 2024
Copy link

melvin-bot bot commented Aug 9, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

Copy link

melvin-bot bot commented Aug 13, 2024

@blimpich Huh... This is 4 days overdue. Who can take care of this?

@blimpich
Copy link
Contributor Author

This was deployed to production.

@melvin-bot melvin-bot bot removed the Overdue label Aug 14, 2024
@github-project-automation github-project-automation bot moved this from Polish to Done in [#whatsnext] #wave-collect Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering
Projects
No open projects
Status: Done
Development

No branches or pull requests

1 participant