Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Search v1] Implement ApproveMoneyRequestOnSearch command #46073

Closed
luacmartins opened this issue Jul 23, 2024 · 20 comments
Closed

[Search v1] Implement ApproveMoneyRequestOnSearch command #46073

luacmartins opened this issue Jul 23, 2024 · 20 comments
Assignees
@johncschuster @lakchote @luacmartins
Labels
Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Jul 23, 2024 •
edited by johncschuster
Loading

Implement this section of the doc for the Approve command only
@luacmartins luacmartins added Daily KSv2 NewFeature Something to build that is a new item. labels Jul 23, 2024
@luacmartins luacmartins self-assigned this Jul 23, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jul 23, 2024

Triggered auto assignment to @johncschuster (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jul 23, 2024
@luacmartins luacmartins added Internal Requires API changes or must be handled by Expensify staff Daily KSv2 and removed Weekly KSv2 labels Jul 23, 2024
@luacmartins luacmartins moved this to Release 2: Summer 2024 (Aug) in [#whatsnext] #wave-collect Jul 23, 2024
@melvin-bot melvin-bot bot added the Overdue label Jul 26, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jul 29, 2024

@johncschuster, @luacmartins Eep! 4 days overdue now. Issues have feelings too...

@luacmartins
Copy link
Contributor Author

No updates yet. I'll start working on it this week.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jul 29, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Aug 2, 2024

@johncschuster, @luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@johncschuster
Copy link
Contributor

Bumping to keep Melvin at bay

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Aug 2, 2024
@johncschuster
Copy link
Contributor

Another bump for Melv

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Aug 5, 2024
@johncschuster
Copy link
Contributor

Bumping for Melv.

@luacmartins, should we keep this at Daily?

@melvin-bot melvin-bot bot removed the Overdue label Aug 8, 2024
@luacmartins
Copy link
Contributor Author

I'll move it to weekly for now since some of this code is still blocked

@luacmartins luacmartins added Weekly KSv2 and removed Daily KSv2 labels Aug 9, 2024
@melvin-bot melvin-bot bot removed the Overdue label Sep 6, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 16, 2024
@johncschuster
Copy link
Contributor

Still on hold

@melvin-bot melvin-bot bot removed the Overdue label Sep 17, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 26, 2024
@johncschuster
Copy link
Contributor

Still on hold

@melvin-bot melvin-bot bot removed the Overdue label Sep 26, 2024
@melvin-bot melvin-bot bot added the Overdue label Oct 7, 2024
@johncschuster
Copy link
Contributor

Still on hold

@melvin-bot melvin-bot bot removed the Overdue label Oct 7, 2024
@melvin-bot melvin-bot bot added the Overdue label Oct 16, 2024
@johncschuster
Copy link
Contributor

Still on hold

@melvin-bot melvin-bot bot removed the Overdue label Oct 16, 2024
@dylanexpensify dylanexpensify moved this from Release 2: Summer 2024 (Aug) to Release 3: Fall 2024 (Nov) in [#whatsnext] #expense Oct 18, 2024
@luacmartins luacmartins changed the title [HOLD Auth NextSteps][Search v1] Implement ApproveMoneyRequestOnSearch command [Search v1] Implement ApproveMoneyRequestOnSearch command Oct 23, 2024
@luacmartins luacmartins added Daily KSv2 and removed Weekly KSv2 labels Oct 23, 2024
@lakchote lakchote self-assigned this Oct 25, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Oct 28, 2024

@johncschuster, @lakchote, @luacmartins Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Oct 28, 2024
@johncschuster
Copy link
Contributor

Oooooh, it looks like we're off hold! 🙌

@melvin-bot melvin-bot bot removed the Overdue label Oct 28, 2024
@lakchote
Copy link
Contributor

lakchote commented Oct 29, 2024 •
edited
Loading

Oooooh, it looks like we're off hold! 🙌

Yes! Auth PR is under review.

@lakchote lakchote mentioned this issue Oct 30, 2024
Merged
60 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Oct 30, 2024
@luacmartins
Copy link
Contributor Author

We can close this issue. I'll handle hooking the command up in App as part of #51898

@github-project-automation github-project-automation bot moved this from Release 3: Fall 2024 (Nov) to Done in [#whatsnext] #expense Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johncschuster johncschuster

@lakchote lakchote

@luacmartins luacmartins

Labels
Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
[#whatsnext] #expense
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@johncschuster @lakchote @luacmartins