[HOLD for payment 2024-08-09] [$250] Workspace - Invited member is allowed to upload workspace avatar, but the upload fails

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.11-2
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• Admin invites employee to a workspace.
• The workspace does not have avatar set up.
• The following steps will be performed by the employee.

1. Go to staging.new.expensify.com
2. Go to workspace settings > Profile.
3. Click on the avatar.
4. Upload an avatar.

Expected Result:

Invited member should not be allowed to upload the workspace avatar (production behavior).

Actual Result:

Invited member is allowed to upload the workspace avatar, but the upload fails.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6551262_1721802951672.20240724_143318.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01cecd7459223b27f7
• Upwork Job ID: 1816065082489022429
• Last Price Increase: 2024-07-24
• Automatic offers:
• ishpaul777 | Reviewer | 103312496

Issue Owner

Current Issue Owner: @muttmuure

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

We think this issue might be related to the #collect project.

[izarutskaya]

Production

bandicam.2024-07-24.12-30-50-687.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01cecd7459223b27f7

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

[grgia]

Making external

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Invited member is allowed to upload the workspace avatar, but the upload fails.

What is the root cause of that problem?

This condition

App/src/components/AvatarWithImagePicker.tsx

Lines 310 to 315 in a79189f

	if (isUsingDefaultAvatar) {
	openPicker({
	onPicked: showAvatarCropModal,
	});
	return;
	}

is placed incorrectly, so if it's default avatar the user can always open picker even though the avatar edit is disabled

What changes do you think we should make in order to solve the problem?

Move

App/src/components/AvatarWithImagePicker.tsx

Lines 310 to 315 in a79189f

	if (isUsingDefaultAvatar) {
	openPicker({
	onPicked: showAvatarCropModal,
	});
	return;
	}

to below here

App/src/components/AvatarWithImagePicker.tsx

Line 319 in a79189f

}

The disabled and enablePreview should always be checked first.

What alternative solutions did you explore? (Optional)

[daledah]

I updated my proposal slightly to clarify the permalink

@grgia I can raise the PR immediately once assigned

[ishpaul777]

Let me quickly verify your solution @daledah

[grgia]

not overdue melvin

[muttmuure]

closing this out tomorrow

[muttmuure]

Invited @daledah

[melvin-bot]

@grgia, @muttmuure, @ishpaul777, @daledah Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[ishpaul777]

This is good to close i think ?

[muttmuure]

Waiting for @daledah to answer invite: https://www.upwork.com/jobs/~01cecd7459223b27f7

[muttmuure]

Bump @daledah

[muttmuure]

Dropping to weekly

[daledah]

@muttmuure Sorry missed this, I applied to the job

[ishpaul777]

All good to close if we are done with payments

[melvin-bot]

@grgia, @muttmuure, @ishpaul777, @daledah Whoops! This issue is 2 days overdue. Let's get this updated quick!

[muttmuure]

Offer is still pending @daledah https://www.upwork.com/nx/wm/offer/103894514

[daledah]

@muttmuure Thanks for bumping, I have accepted

[muttmuure]

Nice, paid