Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Unable to remove the duplicate report #46255

Closed
1 of 6 tasks
m-natarajan opened this issue Jul 26, 2024 · 20 comments
Closed
1 of 6 tasks

[$250] Unable to remove the duplicate report #46255

m-natarajan opened this issue Jul 26, 2024 · 20 comments
Assignees
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Needs Reproduction Reproducible steps needed

Comments

@m-natarajan
Copy link

m-natarajan commented Jul 26, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @luacmartins
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1721851388000539

Action Performed:

  1. Open app
  2. Search for a existing chat
  3. Open the chat which is empty chat with RBR
  4. click on the error to remove it

Expected Result:

Chat should be removed after dismissing error

Actual Result:

Chat is temporarily removed after dismissing error, but shows up again right after

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Screen.Recording.2024-07-24.at.2.01.29.PM.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b16d3cc4ed7023ad
  • Upwork Job ID: 1816906305526740201
  • Last Price Increase: 2024-08-09
Issue OwnerCurrent Issue Owner: @muttmuure
@m-natarajan m-natarajan added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. AutoAssignerNewDotQuality Used to assign quality issues to engineers labels Jul 26, 2024
Copy link

melvin-bot bot commented Jul 26, 2024

Current assignee @luacmartins is eligible for the AutoAssignerNewDotQuality assigner, not assigning anyone new.

@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

Copy link

melvin-bot bot commented Jul 26, 2024

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@OfstadC
Copy link
Contributor

OfstadC commented Jul 26, 2024

OoO today Monday and part of Tuesday so reassigning

@OfstadC OfstadC removed the Bug Something is broken. Auto assigns a BugZero manager. label Jul 26, 2024
@OfstadC OfstadC removed their assignment Jul 26, 2024
@OfstadC OfstadC added the Bug Something is broken. Auto assigns a BugZero manager. label Jul 26, 2024
Copy link

melvin-bot bot commented Jul 26, 2024

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@luacmartins luacmartins added the External Added to denote the issue can be worked on by a contributor label Jul 26, 2024
@melvin-bot melvin-bot bot changed the title Unable to remove the duplicate report [$250] Unable to remove the duplicate report Jul 26, 2024
Copy link

melvin-bot bot commented Jul 26, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01b16d3cc4ed7023ad

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 26, 2024
Copy link

melvin-bot bot commented Jul 26, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

@DylanDylann
Copy link
Contributor

Open the chat which is empty chat with RBR

@luacmartins, could you help detail this step? how we can make an empty chat with RBR?

@luacmartins
Copy link
Contributor

I think that's the part that needs reproduction steps. I think the following happened to me:

  1. Search for a chat that you know exists
  2. Click on it
  3. For some reason, App didn't have that chat locally and tried to create a new optimistic one
  4. The optimistic chat creation failed and shows up as empty with RBR

Not sure how to reliably reproduce step 3.

@muttmuure
Copy link
Contributor

This one needs logs and the network request payload I think

@muttmuure muttmuure moved this to CRITICAL in [#whatsnext] #quality Jul 30, 2024
@luacmartins
Copy link
Contributor

Here you go:

logs.txt
response.json

@DylanDylann
Copy link
Contributor

Screen.Recording.2024-08-01.at.17.55.18.mov

@luacmartins I still can't reproduce this bug after creating a mock data (from response.json file)

Onyx.merge("reportActions_4883141066174784", {
    "7303812203333978888": {
        "errors": {
            "1722354439177636": "You don't have access to this chat room."
        }
    }
})

If you still can reproduce this bug, please help to provide report data (report happen error) and reportAction data (report action happen error) on Onyx

@DylanDylann
Copy link
Contributor

DylanDylann commented Aug 1, 2024

@luacmartins You can use this PR to easily get onyx data

See the below video about how get data

Screen.Recording.2024-08-01.at.18.03.23.mov

Copy link

melvin-bot bot commented Aug 2, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Aug 6, 2024

@luacmartins, @muttmuure, @DylanDylann Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Aug 6, 2024
@muttmuure
Copy link
Contributor

Is this still happening?

@muttmuure muttmuure removed the Overdue label Aug 7, 2024
@melvin-bot melvin-bot bot added the Overdue label Aug 7, 2024
@muttmuure
Copy link
Contributor

Not overdue

@melvin-bot melvin-bot bot removed the Overdue label Aug 7, 2024
Copy link

melvin-bot bot commented Aug 9, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Aug 9, 2024

@luacmartins @muttmuure @DylanDylann this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Aug 9, 2024
@luacmartins
Copy link
Contributor

I can't reproduce this anymore, so I'm gonna close it for now.

@melvin-bot melvin-bot bot removed the Overdue label Aug 12, 2024
@github-project-automation github-project-automation bot moved this from CRITICAL to Done in [#whatsnext] #quality Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Needs Reproduction Reproducible steps needed
Projects
Development

No branches or pull requests

6 participants