Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[$250] Cleanup: move ComposerRef to the ComposerWithSuggestion where its implemented #46499

Closed
hannojg opened this issue Jul 30, 2024 · 10 comments
Closed

[$250] Cleanup: move ComposerRef to the ComposerWithSuggestion where its implemented #46499

hannojg opened this issue Jul 30, 2024 · 10 comments
Assignees
@puneetlath @Ollyws @hannojg @kirillzyusko
Labels
Reviewing Has a PR in review Weekly KSv2

Comments

@hannojg
Copy link
Contributor

hannojg commented Jul 30, 2024 •
edited
Loading

There is the ComposerRef type which is being used in ReportActionCompose. The ref however is implemented inComposerWithSuggestion and it would be more natural to have that close together, and then let ReportActionCompose import it.

Ref: #46091 (comment)
@melvin-bot melvin-bot bot added the Monthly KSv2 label Aug 2, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 2, 2024
@puneetlath
Copy link
Contributor

@hannojg are you planning on tackling this?

@melvin-bot melvin-bot bot removed the Overdue label Sep 4, 2024
@hannojg
Copy link
Contributor Author

hannojg commented Sep 5, 2024

As I am going OOO tomorrow @kirillzyusko can you do this little cleanup please!

@kirillzyusko
Copy link
Contributor

Sure, feel free to assign me on this ticket!

@kirillzyusko kirillzyusko mentioned this issue Sep 9, 2024
Merged
48 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Monthly KSv2 labels Sep 9, 2024
@kirillzyusko
Copy link
Contributor

I think it can be closed because PR got merged 👀

@Ollyws
Copy link
Contributor

Ollyws commented Sep 13, 2024

I'm due payment for C+ review, thanks.

@puneetlath puneetlath changed the title Cleanup: move ComposerRef to the ComposerWithSuggestion where its implemented [$250] Cleanup: move ComposerRef to the ComposerWithSuggestion where its implemented Sep 16, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Sep 16, 2024

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

@Ollyws
Copy link
Contributor

Ollyws commented Sep 19, 2024

This one is due for payment today if someone could handle it, thanks.

@puneetlath
Copy link
Contributor

Payment summary:

  • $250 - C+ - @Ollyws - to be paid via NewDot

@Ollyws
Copy link
Contributor

Ollyws commented Sep 21, 2024

Requested in ND.

@garrettmknight
Copy link
Contributor

$250 approved for @Ollyws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@puneetlath puneetlath

@Ollyws Ollyws

@hannojg hannojg

@kirillzyusko kirillzyusko

Labels
Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@puneetlath @garrettmknight @Ollyws @hannojg @kirillzyusko