Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat - List of mentioned accounts cover the typed text when composer has multiple lines #46622

Closed
6 tasks
m-natarajan opened this issue Jul 31, 2024 · 10 comments
Closed
6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@m-natarajan
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.15-4
Reproducible in staging?: y
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4802024&group_by=cases:section_id&group_order=asc&group_id=290914
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Go to any chat and tap to compose a message
  2. Add seven lines of text
  3. Type @

Expected Result:

The list of mentioned accounts do not cover the typed line

Actual Result:

The list of mentioned accounts cover the typed line and user can't see what its typed

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6558637_1722462614576.az_recorder_20240801_004522.mp4

View all open jobs on GitHub

@m-natarajan m-natarajan added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Jul 31, 2024
Copy link

melvin-bot bot commented Jul 31, 2024

Triggered auto assignment to @deetergp (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jul 31, 2024

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jul 31, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@m-natarajan
Copy link
Author

We think that this bug might be related to #vip-vsb

@roryabraham roryabraham removed the DeployBlocker Indicates it should block deploying the API label Jul 31, 2024
@roryabraham
Copy link
Contributor

Maybe caused by #46091? Will create an AdHoc build of a revert to test

@kadiealexander
Copy link
Contributor

@roryabraham should I assign you?

@roryabraham
Copy link
Contributor

no

@roryabraham
Copy link
Contributor

requested retest with AdHoc build: https://expensify.slack.com/archives/C9YU7BX5M/p1722531831074969

@roryabraham
Copy link
Contributor

roryabraham commented Aug 1, 2024

we merged a revert of #46091 after confirming the fix w/ an AdHoc build and Applause

@roryabraham roryabraham assigned roryabraham and unassigned deetergp Aug 1, 2024
@kavimuru
Copy link

kavimuru commented Aug 1, 2024

Issue is fixed in the latest staging 9.0.15-8

az_recorder_20240801_221019.mp4

@roryabraham roryabraham removed the DeployBlockerCash This issue or pull request should block deployment label Aug 1, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants