Android - Room - Enter key saves the room description instead of entering the next line

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.15-4
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• Device keyboard must be Samsung keyboard.
• This issue is not reproducible with Gboard.

1. Launch New Expensify app.
2. Go to any room.
3. Tap on the room header.
4. Tap on Room description.
5. Enter some text.
6. Tap Enter on the keyboard.

Expected Result:

Enter key will enter the next line (production behavior with Samsung keyboard).

Actual Result:

Enter key saves the room description instead of entering the next line.

This issue is only reproducible on Samsung keyboard and not Gboard.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6558711_1722469785650.1722469611748_Screen_Recording_20240801_074553_New_Expensify.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @rayane-djouah

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

We think this issue might be related to the #vip-vsb

[izarutskaya]

Production

Screen_Recording_20240801_121709_New.Expensify.mp4

[huult]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Enter key saves the room description instead of entering the next line

What is the root cause of that problem?

Missing disablePressOnEnter in FormProvider to disable saving on Enter key press.

What changes do you think we should make in order to solve the problem?

Add disablePressOnEnter in FormProvider to disable saving on Enter key press.

// src/pages/RoomDescriptionPage.tsx#L76

              <FormProvider
                    style={[styles.flexGrow1, styles.ph5]}
                    formID={ONYXKEYS.FORMS.REPORT_DESCRIPTION_FORM}
                    onSubmit={submitForm}
                    submitButtonText={translate('common.save')}
                    enabledWhenOffline
+                   disablePressOnEnter
                >

POC

Screen_Recording_20240801_132510_New.Expensify.Dev.mp4

[MonilBhavsar]

Demoting from blocker as it happens on samsung keyboards only. Commented on the suspicious PR. I think this should be handled as a regression

[rayane-djouah]

@nyomanjyotisa Could you please take a look at this issue?
I think we should enable disablePressOnEnter when one of the form inputs has shouldSubmitForm as false and it's focused

App/src/components/Form/InputWrapper.tsx

Line 57 in 1a93406

shouldSubmitForm: !!shouldSubmitForm,

[MonilBhavsar]

Thank you for looking. If you don't mind, I'll assign you to this issue as a C+

[nyomanjyotisa]

Sure, will check and create a follow up PR today

[MonilBhavsar]

Thank you @nyomanjyotisa! I have assigned you to the issue

[rayane-djouah]

Any update here @nyomanjyotisa ? 😃

[nyomanjyotisa]

@rayane-djouah PR ready for review

[rayane-djouah]

PR on staging

[rayane-djouah]

@MonilBhavsar We can close this one. No payment is due.

[MonilBhavsar]

Sounds good, thanks all for the help!