Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XERO: Pay elsewhere button reappears when tap on it in Submitted expense #46685

Closed
3 of 6 tasks
m-natarajan opened this issue Aug 1, 2024 · 8 comments
Closed
3 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Weekly KSv2

Comments

@m-natarajan
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when validating #46127
Version Number: v9.0.15-4
Reproducible in staging?: y
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

Precondition: Workspace is connected to Xero. Delayed submission is enabled in Workflows

  1. Go to https://staging.new.expensify.com/

  2. Log in

  3. Go to workspace chat

  4. Submit an expense

  5. In the chat, click on the pay elsewhere dropdown

  6. Pay elsewhere the report

Expected Result:

Pay elsewhere button should not reappear

Actual Result:

Pay elsewhere button reappears when click on it in Submitted expense in Xero connected workspace

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6559549_1722540932518.A_fix_Xero_action_modal_positioning_and_display_circle_icon_instead.mp4

View all open jobs on GitHub

@m-natarajan m-natarajan added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Aug 1, 2024
Copy link

melvin-bot bot commented Aug 1, 2024

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Aug 1, 2024

Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Aug 1, 2024
Copy link
Contributor

github-actions bot commented Aug 1, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@roryabraham
Copy link
Contributor

having a tough time connecting Xero in NewDot dev...

@roryabraham
Copy link
Contributor

managed to set up Xero in NewDot dev, but it seems like @marcaaron, @francoisl and I are all unable to reproduce this one on dev

@roryabraham roryabraham added Weekly KSv2 Needs Reproduction Reproducible steps needed and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 DeployBlocker Indicates it should block deploying the API labels Aug 2, 2024
@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@roryabraham
Copy link
Contributor

Demoting per discussion in slack: https://expensify.slack.com/archives/C01GTK53T8Q/p1722555769521659

@melvin-bot melvin-bot bot added the Overdue label Aug 12, 2024
@garrettmknight garrettmknight added retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause and removed Needs Reproduction Reproducible steps needed labels Aug 12, 2024
@garrettmknight
Copy link
Contributor

@m-natarajan can you reproduce? I couldn't either, so I'm going to close, but please reopen if you have luck reproducing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants