[$250] Report field - Report field items are selectable with no action when imported via connection

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.16-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• Workspace is connected to Sage Intacct
• Locations data is imported as report fields in Accounting > Import > Locations

1. Launch New Expensify app
2. Go to workspace settings
3. Go to Report fields
4. Tap on the checkbox
5. Tap on the report field
6. Long press on the list value
7. Tap Select

Expected Result:

In Step 4, checkbox should not appear in report field list
In Step 6, no action should be triggered when long pressing on the list value

Actual Result:

In Step 4, checkbox appears in report field list
In Step 6, Select option is present when long pressing on the list value
In Step 7, after selecting "Select" option, the list value is selected but no action is available
This issue only happens when report fields are imported via connection

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6559927_1722574318836.ScreenRecording_08-02-2024_12-46-09_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0113fbb6b53117c482
• Upwork Job ID: 1820803224934120203
• Last Price Increase: 2024-08-13
• Automatic offers:
• suneox | Reviewer | 103526879

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

We think that this bug might be related to #wave-control

[lanitochka17]

@zanyrenney FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[zanyrenney]

cc @ryanldonato @yuwenmemon @lakchote

You might want to add this to the list of Polish items/handle internally!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0113fbb6b53117c482

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

[melvin-bot]

@suneox, @zanyrenney Whoops! This issue is 2 days overdue. Let's get this updated quick!

[suneox]

We're still looking proposal

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@suneox, @zanyrenney Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[suneox]

We’re still looking for proposals. I’ve posted issue on slack to get more eyes

[hungvu193]

Look like this required SageIntacct credentials. I can take a look 😄

[suneox]

Look like this required SageIntacct credentials. I can take a look 😄

@hungvu193 sure, waiting for @zanyrenney to reassign

[daledah]

Edited by proposal-police: This proposal was edited at 2024-08-14 05:12:17 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

1. Selection mode is enabled even if there's no actions in report fields page
2. Same problem in report field values page but selection only on long press

What is the root cause of that problem?

1. canSelectMultiple is always true if hasAccountingConnections:

App/src/pages/workspace/reportFields/WorkspaceReportFieldsPage.tsx

Line 80 in 7543eae

const canSelectMultiple = !hasAccountingConnections && shouldUseNarrowLayout ? selectionMode?.isEnabled : true;

but we hide the header buttons (actions) if hasAccountingConnections:

App/src/pages/workspace/reportFields/WorkspaceReportFieldsPage.tsx

Line 262 in 7543eae

{!shouldUseNarrowLayout && !hasAccountingConnections && getHeaderButtons()}

2. This attribute is always true:

App/src/pages/workspace/reportFields/ReportFieldsListValuesPage.tsx

Line 325 in 7543eae

turnOnSelectionModeOnLongPress

What changes do you think we should make in order to solve the problem?

1. We should completely disable selection mode if we had accounting connections because there's no corresponding actions on selection:

• Reuse the below logic, note to replace isSmallScreenWidth with shouldUseNarrowLayout:

App/src/pages/workspace/reportFields/ReportFieldsListValuesPage.tsx

Line 69 in 7543eae

const canSelectMultiple = !hasAccountingConnections && (isSmallScreenWidth ? selectionMode?.isEnabled : true);

• Set this to !hasAccountingConnections as well to prevent selection on long press:

App/src/pages/workspace/reportFields/WorkspaceReportFieldsPage.tsx

Line 297 in 7543eae

turnOnSelectionModeOnLongPress

2. Do the same for ReportFieldsListValuesPage

[melvin-bot]

Triggered auto assignment to @grgia, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @daledah You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[hungvu193]

@zanyrenney This issue is now ready for payment I believe

[zanyrenney]

@hungvu193 @daledah invited you both to the job.

[zanyrenney]

payment summary

@daledah owed $250 awaiting upwork acceptance
@hungvu193 owed $250 paid via ND.

[hungvu193]

Requested on ND

[garrettmknight]

$250 approved for @hungvu193

[daledah]

@daledah owed $250 awaiting upwork acceptance

@zanyrenney Sorry missed this, I applied to the job

[melvin-bot]

This issue has not been updated in over 15 days. @hungvu193, @grgia, @zanyrenney, @daledah eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[hungvu193]

Let's close this one 😄

[daledah]

@zanyrenney Sorry missed this, I applied to the job

@zanyrenney I haven't beed paid here, could you reopen the issue to handle it, thx

[zanyrenney]

Hey @daledah - paid this all out now.