[P2P Distance] - Group chat avatar changes after splitting distance expense with existing users

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when validating #42302
Version Number: 9.0.18-0
Reproducible in staging?: Y
Reproducible in production?: New Feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause Internal Team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to FAB > Split expense > Distance.
3. Enter waypoints > Next.
4. Select two existing users.
5. Split the distance expense.

Expected Result:

The group chat style will remain the same (avatar and report details RHP name).

Actual Result:

The group chat style changes after splitting the distance expense. Avatar changes to stacked avatars style and report details RHP name is "chat report".## Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6565068_1723072191475.20240808_070525.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @mountiny (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

We think that this bug might be related to #vip-split

[mountiny]

Does not feel like a deploy blocker as this is a new feature and UX issue.

@neil-marcellini do you want to take this one over as its related to the distance split project. It looks like as if we are creating the old group chat style in the backend instead of the new GroupDM

[melvin-bot]

Current assignee @Christinadobrzyn is eligible for the NewFeature assigner, not assigning anyone new.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

[shawnborton]

@marcaaron can you please have a look at this, as I think it relates to the group chat stuff you had worked on? Thanks!

[marcaaron]

It looks like as if we are creating the old group chat style in the backend instead of the new GroupDM

We should definitely not be doing that.

Taking a quick look but seems like maybe this issue should be labeled Internal and assigned to @neil-marcellini.

[Christinadobrzyn]

Just checking in on this - @neil-marcellini do you have an update? thank you!

[neil-marcellini]

I got a fix up for review!

[neil-marcellini]

Head's up, I'll be working 50% for the rest of this week and next 🌲

[Christinadobrzyn]

PR in staging - getting close!

[neil-marcellini]

Deployed to prod, all done