Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign in – Blank page opens when login via magic link and click on Just sign in here #47053

Closed
3 of 6 tasks
IuliiaHerets opened this issue Aug 8, 2024 · 8 comments
Closed
3 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.18-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4834115
Email or phone of affected tester (no customers): applausetester+jp_48824@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. In Sign in page enter new Expensify email
  3. Open email and copy Magic link
  4. In Incognito tab navigate via Magic link changed to staging
  5. Click on Just sign in here link

Expected Result:

User is logged in

Actual Result:

Blank page opens

Workaround:

Anknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6565253_1723092351551.Sign_in.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Aug 8, 2024
Copy link

melvin-bot bot commented Aug 8, 2024

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Aug 8, 2024

Triggered auto assignment to @danieldoglas (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Aug 8, 2024
Copy link
Contributor

github-actions bot commented Aug 8, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@IuliiaHerets
Copy link
Author

We think that this bug might be related to #vip-vsb

@danieldoglas danieldoglas removed DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels Aug 8, 2024
@danieldoglas
Copy link
Contributor

@iwiznia and I were not able to simulate this error.

@IuliiaHerets can you please retest this and rewrite the reproduction steps if you can still see it happening?

Thanks

@danieldoglas danieldoglas added Daily KSv2 and removed Hourly KSv2 labels Aug 8, 2024
@iwiznia
Copy link
Contributor

iwiznia commented Aug 8, 2024

The video makes it seem that you pasted the magic link into an incognito browser that already has a user logged in in another tab.

@dangrous
Copy link
Contributor

dangrous commented Aug 8, 2024

if this turns out to be a bug it might be due to #46623 since seems related?

@danieldoglas
Copy link
Contributor

Closing this. We were not able to simulate, and this flow is being worked on another issues already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants