Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] IOU - Infinite spinner loading on Submit button when back online after adding stop offline #47146

Closed
2 of 5 tasks
izarutskaya opened this issue Aug 9, 2024 · 8 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API DeployBlockerCash This issue or pull request should block deployment Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Hourly KSv2

Comments

@izarutskaya
Copy link

izarutskaya commented Aug 9, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.18-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4836952&group_by=cases:section_id&group_order=asc&group_id=296765
Email or phone of affected tester (no customers): gocemate+a885@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Start a distance request
  2. Enter the address to the start e.g: "45n N Beach Rd, FL"
  3. Click on add stop
  4. Enter the address, e.g: "Beach Access Path, Sunny Isles Beach, FL"
  5. Click Next button
  6. Click Submit button
  7. Go offline
  8. Go to transaction thread page> Click on Distance> Add a stop point e.g: "Miami Beach"> Submit
  9. Go back online
  10. Verify the map does not shows the route
  11. Click on Distance again

Expected Result:

Map should show the route and Submit button should response

Actual Result:

Map does not show the route when come back online, Submit button is irresponsible

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • [x MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6566457_1723191161207.Recording__3671.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019eb0338dff8112cc
  • Upwork Job ID: 1821982776695149158
  • Last Price Increase: 2024-08-09
Issue OwnerCurrent Issue Owner: @ZhenjaHorbach
@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Aug 9, 2024
Copy link

melvin-bot bot commented Aug 9, 2024

Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Aug 9, 2024

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link
Contributor

github-actions bot commented Aug 9, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@izarutskaya
Copy link
Author

We think this issue might be related to the #collect project.

@neil-marcellini neil-marcellini added the External Added to denote the issue can be worked on by a contributor label Aug 9, 2024
@melvin-bot melvin-bot bot changed the title IOU - Infinite spinner loading on Submit button when back online after adding stop offline [$250] IOU - Infinite spinner loading on Submit button when back online after adding stop offline Aug 9, 2024
Copy link

melvin-bot bot commented Aug 9, 2024

Job added to Upwork: https://www.upwork.com/jobs/~019eb0338dff8112cc

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 9, 2024
Copy link

melvin-bot bot commented Aug 9, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External)

@neil-marcellini
Copy link
Contributor

I'll see if I can reproduce on dev now and then start debugging.

@neil-marcellini
Copy link
Contributor

Weird, I can't really reproduce on dev. Trying on staging. I think this was fixed somehow. I even tried to reproduce outside of the p2p distance beta, and I can't, so I'm going to close this out.

distance-update1080.mov

@neil-marcellini neil-marcellini closed this as not planned Won't fix, can't repro, duplicate, stale Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API DeployBlockerCash This issue or pull request should block deployment Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Hourly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants