Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop - Chat - No tooltip for WS chat for a new user #47169

Closed
1 of 6 tasks
IuliiaHerets opened this issue Aug 9, 2024 · 6 comments
Closed
1 of 6 tasks

Desktop - Chat - No tooltip for WS chat for a new user #47169

IuliiaHerets opened this issue Aug 9, 2024 · 6 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.18-1
Reproducible in staging?: Y
Reproducible in production?: Y
The issue was found when executing this PR #45390
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause Internal Team

Action Performed:

Precondition: user is an admin of workspace.

  1. Invite an employee, a user that does not yet have an Expensify account
  2. Check employee's email for the invitation
  3. Open the new.expensify.com link from the email in a different browser
  4. Choose open desktop application

Expected Result:

Employee is signed in desktop app.
Tooltip shows over the composer's Create button saying Get started! Submit your first expense or ¡Empecemos! Presenta tu primer gasto

Actual Result:

An error appears on login page - 'Incorrect magic code'. If user reloads browser page with a opened link again and choose open desktop app for a second time, user will sign in app.
No tooltip shows over the composer's Create button

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6565650_1723124862960.desktop_invite.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 9, 2024
Copy link

melvin-bot bot commented Aug 9, 2024

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@IuliiaHerets
Copy link
Author

We think that this bug might be related to #wave-collect - Release 1

@IuliiaHerets
Copy link
Author

@johncschuster FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@trjExpensify
Copy link
Contributor

@kavimuru I'm not sure if this is really a bug. The tester's second session was on Desktop. 🤔 It's also incredibly unlikely some new user will sign in to an installed desktop app first.

Nevertheless, let's make sure the tooltip does appear on desktop in the right conditions. As such, can you re-test but do the following:

  1. Invite a new user to a workspace
  2. Sign out of the desktop app if already signed-in
  3. Sign in on the desktop app as the new user (not via the email invite link and web > desktop redirect)
  4. Enter the magic code
  5. Does the tooltip appear?

@kavimuru
Copy link

kavimuru commented Aug 9, 2024

@trjExpensify Following your steps, tooltip does appear.

desktop.invite.mp4

@trjExpensify
Copy link
Contributor

Great, going to close this then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

4 participants