[Performance] Simplify isOneOnOneChat Logic and Improve Performance in getParticipantsAccountIDsForDisplay

[gedu]

Problem

The current implementation of the isOneOnOneChat function uses a complex approach involving mapping and filtering over the participants in the report object. This includes parsing string keys to numbers and filtering out the current user, which can be streamlined for better readability and performance. Additionally, the getParticipantsAccountIDsForDisplay function includes extra mapping and string-to-number parsing inside filters, leading to inefficiencies.

Solution

Refactor the isOneOnOneChat function to a simpler approach that avoids unnecessary mapping and filtering. Instead, directly manipulate the participant count and presence of the current user to determine if the chat is one-on-one. Likewise, improve the getParticipantsAccountIDsForDisplay function by moving the string-to-number parsing out of the filter to increase efficiency.

[gedu]

Hi, I'm Edu from Callstack and I want to work on this issue

[melvin-bot]

Triggered auto assignment to @Beamanator, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[Beamanator]

discussing a bit in slack here

[ZhenjaHorbach]

@Beamanator
I have a small question 😅

Since I reviewed this performance issue, am I eligible for a payment?

And If yes

Looks like production deploy automation failed: This should be on [HOLD for Payment 2024-09-06] according to prod deploy checklist, confirmed in slack

[melvin-bot]

This issue has not been updated in over 15 days. @Beamanator eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Beamanator]

@gedu any update on the discussions you linked here? #47300 (comment)

@ZhenjaHorbach good call, i do believe you deserve payment! I think we can wait to see if the performance issue caused a regression or not before doing payment 🙏

[ZhenjaHorbach]

@gedu any update on the discussions you linked here? #47300 (comment)

@ZhenjaHorbach good call, i do believe you deserve payment! I think we can wait to see if the performance issue caused a regression or not before doing payment 🙏

Thanks !
And I don't mind waiting a little longer 😃
Although this PR has been in production for almost 2 weeks now

[OfstadC]

@Beamanator Let me know what you need from me here 😃

[Beamanator]

I ping'd @gedu in the PR here, I think it makes sense to pay this out since, as @ZhenjaHorbach mentioned, the PR has been in prod for 2 weeks 🙏

[gedu]

The PR is merged and without regressions, should be all good, @Beamanator replied on the PR

[OfstadC]

@ZhenjaHorbach Could you please accept the offer here? Then I can issue payment 😃

[ZhenjaHorbach]

@ZhenjaHorbach Could you please accept the offer here? Then I can issue payment 😃

Done !

[OfstadC]

Payment Summary

• @ZhenjaHorbach paid $250 via Upwork