[hold for payment 2024-09-10] [3rd Party Feeds] Card Feed Settings

[robertjchen]

Part of the Third Party Workspace Feeds project

Main issue: https://github.com/Expensify/Expensify/issues/394008
Doc section: Doc Link
Project:

Feature Description

• Card Feed Settings (@narefyev91 , @waterim )
• Feed Selector (@koko57)

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014f1e4d902cd62bfc
• Upwork Job ID: 1823734663119215844
• Last Price Increase: 2024-08-14
• Automatic offers:
• rayane-djouah | Reviewer | 103602407

Issue Owner

Current Issue Owner: @rayane-djouah

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[joekaufmanexpensify]

@narefyev91 @waterim @koko57 could you please comment so I can assign you?

[narefyev91]

Hey! I'm Nicolay from Callstack - will work on this issue. Thansk!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014f1e4d902cd62bfc

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

[joekaufmanexpensify]

@narefyev91 is there an order of operations for which issues you're focusing on first?

[joekaufmanexpensify]

Pending starting on this

[melvin-bot]

@narefyev91, @joekaufmanexpensify, @rayane-djouah Huh... This is 4 days overdue. Who can take care of this?

[rayane-d]

Pending PR

[koko57]

I will work on Feed Selector

[joekaufmanexpensify]

Assigned!

[melvin-bot]

📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[VickyStash]

Hi! I'm Viktoryia from Callstack, and I'll take over Agata's Feed Selector part

[VickyStash]

The PR with Feed Selector page implementation has been opened for review.

[dubielzyk-expensify]

Also when @dannymcclain gets back - curious for both of your opinions - do we want those separated into different components, or use variants?

I think one component with multiple variants is the right move here. Keen on @dannymcclain 's thoughts too

[joekaufmanexpensify]

PR in review.

[melvin-bot]

Triggered auto assignment to @Gonals, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[ZhenjaHorbach]

@Gonals @joekaufmanexpensify
Could you please assign me here since I reviewed the PR?

[joekaufmanexpensify]

Done!

[joekaufmanexpensify]

Both PRs merged here

[robertjchen]

Thanks!

[ZhenjaHorbach]

I suppose I am entitled to payment after the end of the regressive period

[joekaufmanexpensify]

Yep! Reopening for now. Last PR deployed to prod on September 10th, so payment is due then.

[ZhenjaHorbach]

Yep! Reopening for now. Last PR deployed to prod on September 10th, so payment is due then.

Thanks !

[joekaufmanexpensify]

Course!

[joekaufmanexpensify]

Okay, only payment here is $250 to @ZhenjaHorbach for C+ review via Upwork.

[joekaufmanexpensify]

@ZhenjaHorbach offer sent for $250!

[joekaufmanexpensify]

@rayane-djouah you have an auto-upwork offer for this job, but I don't see that you reviewed any PRs here, so closing it without payment. LMK if that is not correct.

[ZhenjaHorbach]

@ZhenjaHorbach offer sent for $250!

Done !

[joekaufmanexpensify]

@ZhenjaHorbach $250 sent and contract ended!

[joekaufmanexpensify]

Upwork job closed.

[joekaufmanexpensify]

All set, thanks everyone!