QBO - RBR appears next to Accounting when app is syncing with QBO

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.20-0
Reproducible in staging?: Y
Reproducible in production?: N
Issue was found when executing this PR: #46671
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings > Accounting.
3. Connect to QBO.

Expected Result:

RBR will not appear next to Accounting when app is syncing with QBO.
It should only appear when there is connection error.

Actual Result:

RBR appears next to Accounting when app is syncing with QBO.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6571570_1723598486802.20240814_091907.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @cristipaval (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 1

[daledah]

Edited by proposal-police: This proposal was edited at 2024-08-14 08:17:47 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

RBR appears next to Accounting when app is syncing with QBO.

What is the root cause of that problem?

We're using PolicyUtils.hasSyncError to show RBR. However, we're assuming that isSyncInProgress is always false when calling to getSynchronizationErrorMessage:

App/src/libs/PolicyUtils.ts

Line 93 in 44f789a

return (Object.keys(policy?.connections ?? {}) as ConnectionName[]).some((connection) => !!getSynchronizationErrorMessage(policy, connection, false));

Later cause this check to fail:

App/src/libs/actions/connections/index.ts

Lines 381 to 385 in 44f789a

	const connection = policy?.connections?.[connectionName];
	if (isSyncInProgress || connection?.lastSync?.isSuccessful) {
	return;
	}
	return `${syncError} ("${connection?.lastSync?.errorMessage}")`;

Basically, if the sync is in progress, we would skip any error check.

What changes do you think we should make in order to solve the problem?

Check isSyncInProgress appropriately following:

App/src/pages/workspace/accounting/PolicyAccountingPage.tsx

Lines 222 to 226 in 0469cd0

	const isSyncInProgress =
	!!connectionSyncProgress?.stageInProgress &&
	(connectionSyncProgress.stageInProgress !== CONST.POLICY.CONNECTIONS.SYNC_STAGE_NAME.JOB_DONE || !policy.connections?.[connectionSyncProgress.connectionName]) &&
	isValid(lastSyncProgressDate) &&
	differenceInMinutes(new Date(), lastSyncProgressDate) < CONST.POLICY.CONNECTIONS.SYNC_STAGE_TIMEOUT_MINUTES;

[cristipaval]

Discussing it here

@hungvu193 and @war-in as the authors of the offending PR will fix it soon.

[cristipaval]

If this won't be fixed before the production deploy, it could be demoted IMO 🤔

[hungvu193]

It's getting late here. I'll raise a PR to fix this one tomorrow morning 😄

[Beamanator]

Love it 👍 demoting 👍

[arosiclair]

This also has the same root cause as #44148. Closing this out in favor of that issue.