Category-Saving GL & payroll code directed to category list instead of specific category

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.20
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4856835
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Tap profile icon -- workspaces-- workspace
3. Tap more features -- enable report field
4. Tap category
5. Tap on a category
6. Rename the category android save it
7. Note user directed to specfic category page
8. Enter GL code & payroll code and save it
9. Note user directed to category list instead of specific category page
10. Edit GL code & payroll code and save it
11. Note user directed to category list instead of specific category page

Expected Result:

Saving GL & payroll code must be directed to specific category page.

Actual Result:

Saving GL & payroll code directed to category list instead of specific category page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6571828_1723625332057.xh.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @danieldoglas (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

We think this issue might be related to the #vip-vsb

[BhuvaneshPatil]

PR which added these changes - #46617

Proposal

Please re-state the problem that we are trying to solve in this issue.

Upon saving GL and payroll code, we are directed to category list instead of specific category page

What is the root cause of that problem?

We are using dismissModal()

App/src/pages/workspace/categories/CategoryGLCodePage.tsx

Lines 35 to 44 in 29fb6bb

	const editGLCode = useCallback(
	(values: FormOnyxValues<typeof ONYXKEYS.FORMS.WORKSPACE_CATEGORY_FORM>) => {
	const newGLCode = values.glCode.trim();
	if (newGLCode !== glCode) {
	Category.setPolicyCategoryGLCode(route.params.policyID, categoryName, newGLCode);
	}
	Navigation.dismissModal();
	},
	[categoryName, glCode, route.params.policyID],
	);

App/src/pages/workspace/categories/CategoryPayrollCodePage.tsx

Lines 35 to 44 in 29fb6bb

	const editPayrollCode = useCallback(
	(values: FormOnyxValues<typeof ONYXKEYS.FORMS.WORKSPACE_CATEGORY_FORM>) => {
	const newPayrollCode = values.payrollCode.trim();
	if (newPayrollCode !== payrollCode) {
	Category.setPolicyCategoryPayrollCode(route.params.policyID, categoryName, newPayrollCode);
	}
	Navigation.dismissModal();
	},
	[categoryName, payrollCode, route.params.policyID],
	);

What changes do you think we should make in order to solve the problem?

We should use goBack() with appropriate fallback route.

With using fallback route to particular category, even when user refreshes it will redirect to correct page.

Navigation.goBack(ROUTES.WORKSPACE_CATEGORY_SETTINGS.getRoute(policyId, categoryName));

Screen.Recording.2024-08-14.at.4.35.02.PM.mov

Screen.Recording.2024-08-14.at.4.39.49.PM.mov

What alternative solutions did you explore? (Optional)

[BhuvaneshPatil]

@allroundexperts In PR it was converted from goBack() to dismissModal(). We can consider for upgrade pages but places pages where we change values. I am not getting that. Can you please explain. Thanks

[allroundexperts]

@BhuvaneshPatil I think it will be safe to change it on the pages where we change values. We can give it a try.

[allroundexperts]

Btw this is really an minor issue when compared with the host of issues that #46617 solves. I think we can demote this to be not a blocker.

[youssef-lr]

@allroundexperts would you like to submit a quick fix?

[allroundexperts]

Sure, please assign this to me and I will raise a PR tomorrow.

[allroundexperts]

PR: #47593

[abdulrahuman5196]

@youssef-lr / @isabelastisser Could you kindly add me as a C+ here for working on the PR review?

[isabelastisser]

@abdulrahuman5196 @allroundexperts I see PR is merged; when is payment due?

[abdulrahuman5196]

It shows 3 weeks ago this PR was pushed to staging. But no production comment. I think automation didn't comment here.

@youssef-lr I am assuming this is already pushed to production. Correct me if wrong? And when was that?

[abdulrahuman5196]

The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

#46617

Determine if we should create a regression test for this bug.

Yes.

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

1. Go to https://staging.new.expensify.com/
2. Tap profile icon -- workspaces-- workspace
3. Tap more features -- enable report field
4. Tap category
5. Tap on a category
6. Rename the category android save it
7. Note user directed to specfic category page
8. Enter GL code & payroll code and save it
9. Note user directed to category list instead of specific category page
10. Edit GL code & payroll code and save it
11. Verify that saving GL & payroll code must be directed to specific category page.

[abdulrahuman5196]

It shows 3 weeks ago this PR was pushed to staging. But no production comment. I think automation didn't comment here.

@youssef-lr I am assuming this is already pushed to production. Correct me if wrong? And when was that?

@youssef-lr / @isabelastisser Could you kindly confirm here?

[youssef-lr]

Yes, looks like automation failed. That PR is in production.

[isabelastisser]

Sorry for the delay here! The payment automation failed and I missed the notification about it.

Payment summary:

$250 for @abdulrahuman5196 for C+ review - payment pending via NewDot.
$250 for @allroundexperts for PR - payment pending via NewDot.

all set.

[JmillsExpensify]

$250 approved for @abdulrahuman5196

[JmillsExpensify]

$250 approved for @allroundexperts