Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-08-22] Search filters - Tag in X: Y format is displayed in X\:Y style #47448

Closed
6 tasks done
IuliiaHerets opened this issue Aug 14, 2024 · 11 comments
Closed
6 tasks done
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Aug 14, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.20-4
Reproducible in staging?: Y
Reproducible in production?: N (Can't check)
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

  • Workspace has a tag in X: Y format.
  1. Go to staging.new.expensify.com/search/filters.
  2. Click Tag.

Expected Result:

Tag in X: Y format will be displayed in X:Y style.

Actual Result:

Tag in X: Y format is displayed in X\:Y style

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

20240815_002902.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @kadiealexander
@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Aug 14, 2024
Copy link

melvin-bot bot commented Aug 14, 2024

Triggered auto assignment to @chiragsalian (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Aug 14, 2024

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Aug 14, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Aug 14, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@IuliiaHerets
Copy link
Author

We think that this bug might be related to #wave-collect - Release 1

@Beamanator
Copy link
Contributor

This one def looks like it's related to #46556 and #47289

@Beamanator
Copy link
Contributor

cc @bernhardoj @getusha

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Aug 14, 2024
@Beamanator Beamanator removed the DeployBlockerCash This issue or pull request should block deployment label Aug 14, 2024
@Beamanator
Copy link
Contributor

Looks fixed in staging! probably can close this out

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Aug 15, 2024
@melvin-bot melvin-bot bot changed the title Search filters - Tag in X: Y format is displayed in X\:Y style [HOLD for payment 2024-08-22] Search filters - Tag in X: Y format is displayed in X\:Y style Aug 15, 2024
Copy link

melvin-bot bot commented Aug 15, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Aug 15, 2024
Copy link

melvin-bot bot commented Aug 15, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.20-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-08-22. 🎊

Copy link

melvin-bot bot commented Aug 15, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

@chiragsalian
Copy link
Contributor

No payment needed here since i solved this internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants