Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] [HOLD for Payment 2024-09-06][Search v2.1] Save button is hidden behind the keyboard on search filters pages on mWeb Safari #47507

Closed
rayane-djouah opened this issue Aug 15, 2024 · 18 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@rayane-djouah
Copy link
Contributor

rayane-djouah commented Aug 15, 2024

Bug reproducible on all the filters pages:

The Save button is hidden behind the keyboard on mWeb Safari (you need to dismiss the keyboard to click on the save button):

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-08-14.at.14.59.08.mp4

cc @luacmartins @SzymczakJ @289Adam289 @Guccio163

Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021831820319934282059
  • Upwork Job ID: 1831820319934282059
  • Last Price Increase: 2024-09-05
Issue OwnerCurrent Issue Owner: @alexpensify
@rayane-djouah rayane-djouah added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Aug 15, 2024
Copy link

melvin-bot bot commented Aug 15, 2024

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@rayane-djouah
Copy link
Contributor Author

This will be handled by SWM

@rayane-djouah rayane-djouah changed the title [Search v2.1] Save button is hidden behind the keyboard on mWeb Safari [Search v2.1] Save button is hidden behind the keyboard on search filters pages on mWeb Safari Aug 15, 2024
@alexpensify
Copy link
Contributor

Ok, I'll wait for the SWM team member to add a comment here, and I can assign them. Thanks for the update!

@melvin-bot melvin-bot bot added the Overdue label Aug 19, 2024
Copy link

melvin-bot bot commented Aug 19, 2024

@alexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@alexpensify
Copy link
Contributor

@SzymczakJ @289Adam289 @Guccio163 - please add a comment, so I can add you here. Thanks!

@289Adam289
Copy link
Contributor

Hi! I can work on this

@alexpensify
Copy link
Contributor

I added you @289Adam289, thanks!

@luacmartins
Copy link
Contributor

Thanks @289Adam289 !

@alexpensify
Copy link
Contributor

Next Steps

This PR is going through the review process.

Heads up, I will be offline until Tuesday, September 3, 2024, and will not actively watch over this GitHub during that period.

If anything urgent is needed here, please ask for help in the #expensify-open-source Slack Room-- thanks!

@luacmartins
Copy link
Contributor

PR is merged, just waiting on deploy

@ikevin127
Copy link
Contributor

⚠️ We just got confirmation on Slack that the Deploy Checklist: New Expensify 2024-08-26 which includes the PR of this issue was only deployed to production today in Deploy Checklist: New Expensify 2024-08-28. More context on why this happened can be found in this Slack thread and this Slack comment.

Given the context above, this issue should be on [HOLD for Payment 2024-09-6] according to today’s production deploy from Deploy Checklist: New Expensify 2024-08-28.

cc @alexpensify @luacmartins

@luacmartins luacmartins changed the title [Search v2.1] Save button is hidden behind the keyboard on search filters pages on mWeb Safari [HOLD for Payment 2024-09-06][Search v2.1] Save button is hidden behind the keyboard on search filters pages on mWeb Safari Sep 2, 2024
@luacmartins luacmartins added Daily KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Reviewing Has a PR in review Weekly KSv2 labels Sep 2, 2024
@alexpensify
Copy link
Contributor

Thanks for flagging, and I noted that payment is on September 6.

@alexpensify alexpensify added the External Added to denote the issue can be worked on by a contributor label Sep 5, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for Payment 2024-09-06][Search v2.1] Save button is hidden behind the keyboard on search filters pages on mWeb Safari [$250] [HOLD for Payment 2024-09-06][Search v2.1] Save button is hidden behind the keyboard on search filters pages on mWeb Safari Sep 5, 2024
Copy link

melvin-bot bot commented Sep 5, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021831820319934282059

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 5, 2024
Copy link

melvin-bot bot commented Sep 5, 2024

Current assignee @ikevin127 is eligible for the External assigner, not assigning anyone new.

@alexpensify
Copy link
Contributor

To prepare for the payment date, I've sent an offer to @ikevin127. I'll complete the process tomorrow.

@ikevin127
Copy link
Contributor

@alexpensify Offer accepted, thank you!

@alexpensify
Copy link
Contributor

alexpensify commented Sep 6, 2024

Payouts due: 2024-09-06

Upwork job is here.

@alexpensify
Copy link
Contributor

Closing - all payment actions are complete here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
Status: Done
Development

No branches or pull requests

5 participants