[hold for payment 2024-09-04] [$250] Update UpdatePolicyConnectionConfiguration to be 1:1:1 - Part 2

[dangrous]

Problem

Our UpdatePolicyConnectionConfiguration API command is not 1:1:1 - it is the same API call for all related user actions, when it should be split up for each connection (QBO, Xero, etc.) and configuration setting (autoSyncVendor, enableNewCategories, etc.). At the end of this we should not call that function anywhere.

This is polish for the Collect QBO project.

Solution

When we created the NetSuite commands, we followed the correct pattern, and so need to do so here too.

This requires backend and frontend work in tandem (to create the commands and then to use them), so we're looking for a contributor(s) to handle the frontend. You can see an example PR here - there is some extra prep work there that you can ignore, but adjusting all calls like this is what we're going for:

- Connections.updatePolicyConnectionConfig(policyID, CONST.POLICY.CONNECTIONS.NAME.QBO, CONST.QUICK_BOOKS_CONFIG.REIMBURSABLE_EXPENSES_ACCOUNT, row.value);
+ QuickbooksOnline.updateQuickbooksOnlineReimbursableExpensesAccount(policyID, row.value);

Here is a list of the commands handled in this issue:

• UpdateXeroImportTrackingCategories
• UpdateXeroImportTaxRates
• UpdateXeroTenantID
• UpdateXeroMappings

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f780930d7cefc51d
• Upwork Job ID: 1825538900212407946
• Last Price Increase: 2024-08-19
• Automatic offers:
• ishpaul777 | Reviewer | 103587463

Issue Owner

Current Issue Owner: @

[ishpaul777]

Picking this up as C+

[hungvu193]

I'll take this one as contributor

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f780930d7cefc51d

[melvin-bot]

Current assignee @ishpaul777 is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[hungvu193]

I'll raise a PR soon

[dangrous]

Backend PR is merged, though not yet on staging, but should be soon!

[dangrous]

Spoke too soon, I guess - this is on staging now, so code away!

[hungvu193]

@dangrous just to confirm:

• UpdateXeroImportTrackingCategories will replace this one
• UpdateXeroImportTaxRates will replace this one
• UpdateXeroTenantID will replace this one
• UpdateXeroMappings will replace this one

[dangrous]

yep perfect! double check that there aren't any other usages but that's it

[hungvu193]

Little update, draft PR is here

[dangrous]

I think this is on prod? I'm going to grab a BZ to handle payment (and also help us figure that out haha)

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[dangrous]

@joekaufmanexpensify we're in the 7 day regression period for this one, but assigned you to help us figure out when this one went to prod and handle payment when payment is needed!

[joekaufmanexpensify]

Going off of this SO and this issue, looks like it went out on the 28th. So payment here should be due today actually.

[joekaufmanexpensify]

Will take care of that now!

[joekaufmanexpensify]

Payment due here is:

• $250 to @hungvu193 for PR via NewDot.
• $250 to @ishpaul777 for C+ via Upwork.

[joekaufmanexpensify]

All set to issue payment!

[joekaufmanexpensify]

@ishpaul777 $250 sent and contract ended!

[joekaufmanexpensify]

Upwork job closed.

[joekaufmanexpensify]

Closing as only thing left here is for @hungvu193 to request payment via NewDot!

[garrettmknight]

$250 approved for @hungvu193