[HOLD for Payment 2024-09-12][$250] Update UpdatePolicyConnectionConfiguration to be 1:1:1 - Part 3

[dangrous]

Problem

Our UpdatePolicyConnectionConfiguration API command is not 1:1:1 - it is the same API call for all related user actions, when it should be split up for each connection (QBO, Xero, etc.) and configuration setting (autoSyncVendor, enableNewCategories, etc.). At the end of this we should not call that function anywhere.

This is polish for the Collect QBO project.

Solution

When we created the NetSuite commands, we followed the correct pattern, and so need to do so here too.

This requires backend and frontend work in tandem (to create the commands and then to use them), so we're looking for a contributor(s) to handle the frontend. You can see an example PR here - there is some extra prep work there that you can ignore, but adjusting all calls like this is what we're going for:

- Connections.updatePolicyConnectionConfig(policyID, CONST.POLICY.CONNECTIONS.NAME.QBO, CONST.QUICK_BOOKS_CONFIG.REIMBURSABLE_EXPENSES_ACCOUNT, row.value);
+ QuickbooksOnline.updateQuickbooksOnlineReimbursableExpensesAccount(policyID, row.value);

Here is a list of the commands handled in this issue:

• UpdateQuickbooksOnlineSyncTax
• UpdateQuickbooksOnlineSyncLocations
• UpdateQuickbooksOnlineSyncCustomers
• UpdateQuickbooksOnlineSyncClasses
• UpdateQuickbooksOnlineNonReimbursableBillDefaultVendor

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015e929ed9349d8a1c
• Upwork Job ID: 1824526517991227480
• Last Price Increase: 2024-08-16
• Automatic offers:
• ishpaul777 | Reviewer | 103558928
• ZhenjaHorbach | Contributor | 103558931

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @twisterdotcom

[ZhenjaHorbach]

@dangrous
Can you assign me, please?

[ishpaul777]

Picking this up as C+

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015e929ed9349d8a1c

[melvin-bot]

Current assignee @ishpaul777 is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @ZhenjaHorbach 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[ZhenjaHorbach]

Not overdue

[ZhenjaHorbach]

Not overdue
Waiting for BE to be ready

[dangrous]

@ZhenjaHorbach backend should be ready to go now!

[ZhenjaHorbach]

@ZhenjaHorbach backend should be ready to go now!

Nice
Thanks for the info !
I'll fill out the checklist for my PR today or over the weekend

[melvin-bot]

@dangrous, @ZhenjaHorbach, @ishpaul777 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[ishpaul777]

PR in works, @ZhenjaHorbach would you please make melvin happy :D

[ZhenjaHorbach]

PR is ready 😃
But we still need to wait BE following this issue

[dangrous]

BE is ready!

[dangrous]

Okay so to confirm here - no update is needed to the failure data because that will be handled in @zfurtak's PR?

[ZhenjaHorbach]

Okay so to confirm here - no update is needed to the failure data because that will be handled in @zfurtak's PR?

I think yes !

[zfurtak]

FYI it's already on main 😁
cc: @ZhenjaHorbach @dangrous

[dangrous]

okay great! so i think we're just waiting the 7 days and then payment! Looks like this was merged to prod 19 hours ago? #47628 (comment)

[ZhenjaHorbach]

okay great! so i think we're just waiting the 7 days and then payment! Looks like this was merged to prod 19 hours ago? #47628 (comment)

Yep
So this should be on [HOLD for Payment 2024-09-12]

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[dangrous]

@twisterdotcom no action needed yet but payment will be due on 2024-09-12!

[ZhenjaHorbach]

@twisterdotcom
We are ready for payment !

[twisterdotcom]

Payment Summary:

• @ishpaul777 paid $250 via Upwork here (C+)
• @ZhenjaHorbach paid $250 via Upwork here (Contributor)

[ZhenjaHorbach]

Payment Summary:

• @ishpaul777 paid $250 via Upwork here (C+)
• @ZhenjaHorbach paid $250 via Upwork here (Contributor)

I actually got an offer 😅
Not a payment
Here is my old offer

@twisterdotcom
Could you please take a look ?

[twisterdotcom]

Okay, paid out that one!