Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Android - Search - Paid & Approved status is not tappable after opening expense in All status #47684

Closed
1 of 6 tasks
IuliiaHerets opened this issue Aug 20, 2024 · 12 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Reviewing Has a PR in review Weekly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Aug 20, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.22-5
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh05081@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

PPrecondition:

  • Physical (real) device is required to reproduce this issue.
  1. Launch New Expensify app.
  2. Go to Search.
  3. Go to Paid.
  4. Note that Paid tab is tappable.
  5. Go to All.
  6. Open any expense.
  7. Tap app back button to return to All.
  8. Scroll the status bar.
  9. Tap on Paid and Approved status.

Expected Result:

Paid and Approved status should be tappable after opening an expense in All tab.

Actual Result:

Paid and Approved status is no longer tappable after opening an expense in All tab.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6576818_1724139189477.Screen_Recording_20240820_135555_New_Expensify__1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0182def85840821943
  • Upwork Job ID: 1825893542863089341
  • Last Price Increase: 2024-08-20
Issue OwnerCurrent Issue Owner: @eVoloshchak
@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Aug 20, 2024
Copy link

melvin-bot bot commented Aug 20, 2024

Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Aug 20, 2024

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@IuliiaHerets
Copy link
Author

We think that this bug might be related to #wave-collect - Release 1

@flodnv
Copy link
Contributor

flodnv commented Aug 20, 2024

Well for me I can't even tap Paid to start with 😕 How about you @joekaufmanexpensify?

This does seem like a blocker.

@flodnv
Copy link
Contributor

flodnv commented Aug 20, 2024

Probably caused by #47181 @luacmartins @arosiclair @rayane-djouah ? I'll let you decide whether this should be a blocker.

@joekaufmanexpensify
Copy link
Contributor

@flodnv I don't have a physical android device. I tried to reproduce via browserstack, but scrolling to the paid tab doesn't work (I assume hence the precondition in the reproduction steps). But I agree if you can't tap the paid tab at all, that does indeed feel like a blocker.

@luacmartins luacmartins added the External Added to denote the issue can be worked on by a contributor label Aug 20, 2024
@melvin-bot melvin-bot bot changed the title Android - Search - Paid & Approved status is not tappable after opening expense in All status [$250] Android - Search - Paid & Approved status is not tappable after opening expense in All status Aug 20, 2024
Copy link

melvin-bot bot commented Aug 20, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0182def85840821943

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 20, 2024
Copy link

melvin-bot bot commented Aug 20, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

@luacmartins
Copy link
Contributor

Yea, that looks like a blocker to me. Adding the external label to get more eyes on it

@luacmartins luacmartins assigned luacmartins and unassigned flodnv Aug 20, 2024
@luacmartins
Copy link
Contributor

I'll take this over since my PR is introducing this feature

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Aug 20, 2024
@luacmartins
Copy link
Contributor

We reverted the offending PR. Closing.

@luacmartins luacmartins removed the DeployBlockerCash This issue or pull request should block deployment label Aug 20, 2024
@luacmartins luacmartins mentioned this issue Aug 20, 2024
60 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants