[$250] [Advanced Approval Workflows]: Implement Sorting

[dylanexpensify]

Coming from this project, we have this follow-up polish issue we need to complete where we implement the ability to sort. More details here.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01078457d0b3153dad
• Upwork Job ID: 1825862467827284233
• Last Price Increase: 2024-08-20

Issue Owner

Current Issue Owner: @

[dylanexpensify]

cc @blazejkustra

[blazejkustra]

Hey! I’m Błażej Kustra from Software Mansion, an expert agency, and I’d like to work on this issue!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01078457d0b3153dad

[melvin-bot]

Current assignee @DylanDylann is eligible for the External assigner, not assigning anyone new.

[dylanexpensify]

Hi @blazejkustra! It's all yours!

[klajdipaja]

Proposal

Please re-state the problem that we are trying to solve in this issue.

During workflow configuration, when the Approver is being selected the list of the members shown for selections is not sorted alphabetically.

What is the root cause of that problem?

There is no sorting applied to the items in the list therefore they have the default ordering from the BE.

What changes do you think we should make in order to solve the problem?

In WorkspaceWorkflowsApprovalsApproverPage.tsx we need to sort the list of the items before they are passed to the Section.

App/src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsApproverPage.tsx

Line 152 in c9954ad

data: filteredApprovers,

Should be replaced with this:

data: OptionsListUtils.sortItemsAlphabetically(filteredApprovers)

App/src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsApproverPage.tsx

Line 357 in c9954ad

data: formattedApprover,

Should be replaced with this:

data: OptionsListUtils.sortItemsAlphabetically(formattedApprover)

App/src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsApproverPage.tsx

Line 363 in c9954ad

data: formattedPolicyEmployeeList,

Should be replaced with this:

data: OptionsListUtils.sortItemsAlphabetically(formattedPolicyEmployeeList)

What alternative solutions did you explore? (Optional)

We could introduce sorting as a capability of the SelectionList component to have ordering built into it, so that when we pass sections to the component we can choose if the section items should be ordered ASC or DESC. That sounds like over engineering to me though.

[melvin-bot]

📣 @klajdipaja! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[klajdipaja]

Contributor details
Your Expensify account email: klajdipaja@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~018cf234fc3c53341a

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[blazejkustra]

PR is ready for your review @DylanDylann

[melvin-bot]

This issue has not been updated in over 15 days. @blazejkustra, @DylanDylann eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[DylanDylann]

@dylanexpensify Please help process the payment for me. Thanks