Android - Nothing happens when selecting Start/Stop option when creating distance request

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.24-0
Reproducible in staging?: Y
Reproducible in production?: N
Issue was found when executing this PR: #47720
Email or phone of affected tester (no customers): applausetester+uo0822@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Open New Expensify app
2. Enter any workspace chat
3. Tap "+" and submit expense
4. Tap distance tab and attempt to add start/stop locations.

Expected Result:

User is able to enter locations

Actual Result:

Nothing happens when tapping Start/stop

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6579577_1724353955440.XRecorder_22082024_142523.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 1

[marcaaron]

I am unable to repro.

[marcaaron]

It does seem like it could be one of the conditions here preventing this (modified in linked PR in this issue's description):

function canUserPerformWriteAction(report: OnyxEntry<Report>) {
    const reportErrors = getAddWorkspaceRoomOrChatReportErrors(report);

    // If the expense report is marked for deletion, let us prevent any further write action.
    if (isMoneyRequestReportPendingDeletion(report)) {
        return false;
    }

    const reportNameValuePairs = getReportNameValuePairs(report?.reportID);
    return !isArchivedRoom(report, reportNameValuePairs) && isEmptyObject(reportErrors) && report && isAllowedToComment(report) && !isAnonymousUser && canWriteInReport(report);
}

But there's not enough information to triage this. Reverting for now and building an ad hoc here.

Next steps: Have tester QA against the ad hoc.

[puneetlath]

QA has confirmed this is passing now. Demoting and closing.