-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tracking] Import phonebook contacts into New Expensify #47938
Comments
First predesign questions:
|
posted first predesign (saving library/implementation details for a 2nd predesign): https://expensify.slack.com/archives/C01GTK53T8Q/p1724440169163019 |
Posted here, but I don't think this is a project for #wave-collect. |
Moved to #f1-25june2025 |
Summarizing all of our predesign decisions and getting this ready for handoff:
|
👋🏻 |
You can use https://github.com/s77rt/react-native-contacts (a Turbo Module) for reference |
@perunt how is the PR going? Can you you give us an update? |
hey @blimpich, we just finished fixing the Nitro issue (the library we use for this module). Tomorrow, I'm going to show some metrics about it and move that module to the Expensify repo |
Sounds great! Thank you for the update 👍 |
Payment Summary
BugZero Checklist (@zanyrenney)
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.78-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-01-02. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Payment Summary
BugZero Checklist (@zanyrenney)
|
Update:After being reverted we have a PR up but we're waiting for @perunt to be added to the Mobile Expensify Repo so that we can thoroughly test the PR to ensure it doesn't break HybridApp. There is an open issue tracking adding new devs to the Mobile-Expensify repo here. Progress has been slow since lots of people are out for holidays. |
@blimpich the Contact Module has been successfully reapplied. Additionally I've bumped Nitro. |
Reached out to engineers familiar with hybrid app here: https://expensify.slack.com/archives/C04878MDF34/p1736210982318679. |
Hey @blimpich, @staszekscp submitted a promising-looking PR for resolving issues here, which was just merged 🎉 |
@perunt can you look at the most recent comments on the PR and merge in |
@DylanDylann are you able to test the PR for hybrid app compatibility? #54459 |
@blimpich I am trying to setup a hybrid app locally. Could we build ad-hoc for hybrid App? |
Proposal: Import phonebook contacts into New Expensify
Strategy
The most important metric we want to see grow in the coming months is new user acquisition 📈. To facilitate that we need to invest in features that streamline viral user growth and make it easier to pull new users into the app. 👥
Problem
If you want to use the Expensify Classic app to invite your team or your boss to Expensify, it’s very easy. You sign up, scan a receipt, and an inbox task will appear asking who you want to send it to. If you click on that, it will open your phone’s contact book and allow you to select the contact(s) that you want to invite to Expensify. You can invite people you know in just a few taps, without leaving the app.
There are a number of other places throughout Expensify Classic where you can easily invite people to Expensify, such as when submitting reports.
Meanwhile, in New Expensify, the first few steps of inviting new users are arguably more streamlined. You immediately scan a receipt, and on the very next page you’ll be asked who you want to share it with. However, at that stage, you need to leave the app to find their email or phone number from some other source and manually type or copy/paste it into NewDot. This introduces friction in a critical viral growth moment.
Solution
Let’s close the gap on one of the final pieces of feature parity between Expensify Classic (mobile) and NewDot, by importing contacts from your phonebook 📕 into New Expensify. This will streamline the process of inviting people you already know into Expensify. Let’s show these imported contacts in any page where we invite new users (start chat, workspace invite, request money participants page, etc…).
All these pages are already set up to invite new users to Expensify via their email or phone number, so the only requirement is to import that information from the contacts app (after obtaining the user’s permission to do so). Because of that, this project is completely front-end and self-contained. That means that after we get through an initial high-level design phase, it can be implemented entirely by external contributors.
For UI inspiration, WhatsApp 📞 shows imported contacts in an “Invite to WhatsApp” section.
Issue Owner
Current Issue Owner: @blimpichThe text was updated successfully, but these errors were encountered: