Video modal - Empty button in Welcome modal & two Learn more buttons in Track expense modal

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.25-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): anyanyanyanaynewnewnenwe2932@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Create a new gmail account.
3. Go through the onboarding.
4. Note that there is a blank button.
5. Click Get started.
6. Click FAB > Track expense.
7. Note that there are two Learn more buttons.

Expected Result:

In Step 4, there will not be a blank button in Welcome modal.
In Step 7, there will be only one Learn more button.

Actual Result:

In Step 4, there is a blank button in Welcome modal.
In Step 7, there are two Learn more buttons.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6583714_1724719131842.bo.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @mountiny (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 1

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[daledah]

Edited by proposal-police: This proposal was edited at 2024-08-27 07:04:08 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

In Step 4, there is a blank button in Welcome modal.
In Step 7, there are two Learn more buttons.

What is the root cause of that problem?

These lines are redundant:

App/src/components/FeatureTrainingModal.tsx

Lines 231 to 237 in 198e6e9

	<Button
	large
	success
	pressOnEnter
	onPress={closeAndConfirmModal}
	text={confirmText}
	/>

because we already had the helpText button above here.

That's why we have 2 Learn more buttons in step 7 and even though the welcome video modal does not have helpText button, we still have it with empty content in step 4.

What changes do you think we should make in order to solve the problem?

Remove that redundant button.

[mountiny]

PR is up, this was a bad merge conflict resolution from the RN upgrade PR I believe

[mountiny]

We can close this one now as there are no payments required

[joekaufmanexpensify]

Thanks Vit!