Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace-Description in workspace greyout in offline without making any changes #48076

Closed
3 of 6 tasks
IuliiaHerets opened this issue Aug 27, 2024 · 7 comments
Closed
3 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Hourly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Aug 27, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.25-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4895431
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/home
  2. Tap profile icon -- workspaces-- new workspace
  3. Tap profile
  4. Turn off mobile data

Expected Result:

Description in workspace must not be greyout in offline without making any changes.

Actual Result:

Description in workspace greyout in offline without making any changes.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6583909_1724739434137.des.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Aug 27, 2024
Copy link

melvin-bot bot commented Aug 27, 2024

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Aug 27, 2024

Triggered auto assignment to @danieldoglas (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Aug 27, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Aug 27, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@Nodebrute
Copy link
Contributor

Nodebrute commented Aug 27, 2024

Edited by proposal-police: This proposal was edited at 2024-08-27 11:57:53 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Description in workspace greyout in offline without making any changes

What is the root cause of that problem?

We are adding description in pending fields here

description: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,

What changes do you think we should make in order to solve the problem?

In the backend response, we don't receive description data when creating a workspace. Therefore, the ideal solution would be to remove this field.

description: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,

What alternative solutions did you explore? (Optional)

If we don't want to remove this then we should also add in success data

pendingFields: {

description: null

@shubham1206agra
Copy link
Contributor

shubham1206agra commented Aug 27, 2024

This is related to #47260, which is a known issue.

cc @isabelastisser @danieldoglas

@shubham1206agra
Copy link
Contributor

Please close this issue.

@puneetlath
Copy link
Contributor

Going to close this as not a blocker since this exists on prod and is being handled in #47260

@puneetlath puneetlath removed the DeployBlockerCash This issue or pull request should block deployment label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants