[$250] Taxes - "Default" label changes to "Workspace currency default" after changing tax code

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.25-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings > Taxes.
3. Click on the default tax code.
4. Click Tax code.
5. Edit tax code and save it.
6. Note that "Default" label in the default tax code in the background changes to "Workspace currency default" briefly.

Expected Result:

"Default" label in the default tax code in the background will not change after changing tax code.

Actual Result:

"Default" label in the default tax code in the background changes to "Workspace currency default" briefly.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6583912_1724739972875.20240827_142325.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e55f0f655d87efe9
• Upwork Job ID: 1828439699555129867
• Last Price Increase: 2024-08-27
• Automatic offers:
• etCoderDysto | Contributor | 103702547
• shubham1206agra | Contributor | 103702642

Issue Owner

Current Issue Owner: @akinwale

[melvin-bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @MariaHCD (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #wave-control

[etCoderDysto]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Default" label changes to "Workspace currency default" after changing tax code

What is the root cause of that problem?

Here were are not setting foreignTaxDefault to the newTaxCode when editing tax code

App/src/libs/actions/TaxRate.ts

Lines 486 to 496 in d5cfecf

	function setPolicyTaxCode(policyID: string, oldTaxCode: string, newTaxCode: string) {
	const policy = allPolicies?.[`${ONYXKEYS.COLLECTION.POLICY}${policyID}`];
	const originalTaxRate = {...policy?.taxRates?.taxes[oldTaxCode]};
	const onyxData: OnyxData = {
	optimisticData: [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
	value: {
	taxRates: {
	defaultExternalID: oldTaxCode === policy?.taxRates?.defaultExternalID ? newTaxCode : policy?.taxRates?.defaultExternalID,

And here default badge is only displayed when taxID === defaultExternalID && taxID === foreignTaxDefault condition holds to be true. And it is not being true, since we are not updating foreignTaxDefault

App/src/pages/workspace/taxes/WorkspaceTaxesPage.tsx

Lines 87 to 91 in d5cfecf

	const textForDefault = useCallback(
	(taxID: string, taxRate: TaxRate): string => {
	let suffix;
	if (taxID === defaultExternalID && taxID === foreignTaxDefault) {
	suffix = translate('common.default');

What changes do you think we should make in order to solve the problem?

We should update foreignTaxDefault with the new tax code in optimistic data here

foreignTaxDefault: oldTaxCode === policy?.taxRates?.foreignTaxDefault ? newTaxCode : policy?.taxRates?.foreignTaxDefault,

And set foreignTaxDefault to the existing foreignTaxDefault in failure data

foreignTaxDefault: policy?.taxRates?.foreignTaxDefault,

Also we shouldn't update defaultExternalID in successData since BE returns the updated value

What alternative solutions did you explore? (Optional)

[etCoderDysto]

Offending pr #47819

cc: @rushatgabhane @cead22

[MariaHCD]

@etCoderDysto's proposal looks good to me 👍🏼

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e55f0f655d87efe9

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

[melvin-bot]

📣 @etCoderDysto 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[etCoderDysto]

Thanks! I will raise a PR in an hour.

[melvin-bot]

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[MariaHCD]

Assigning @shubham1206agra for C+ review

[MariaHCD]

Reassigned the C+ since this was a regression:

https://expensify.slack.com/archives/C02NK2DQWUX/p1724769162552359

[MariaHCD]

@etCoderDysto any updates on the PR just yet?

[etCoderDysto]

@etCoderDysto any updates on the PR just yet?

Sorry, I was on a road. I am working on the PR now. It will be ready for review under 30 minutes.

[puneetlath]

I confirmed this is fixed on staging. Thanks!

[OfstadC]

I think we are just waiting for this to be deployed to production in order to issue payment, but please correct me if I'm wrong.

[etCoderDysto]

@OfstadC this PR was cped on Aug 28. I think the automation is failing. It should be ready for payment.

[OfstadC]

Thanks for clarifying @etCoderDysto ! Sorry for the confusion here 😅

Payment Summary

• @etCoderDysto paid $250 in Upwork
• @shubham1206agra Could you please accept your Upwork offer so I can issue payment? No C+ Payment required

[shubham1206agra]

@OfstadC I did not reviewed the PR. @rushatgabhane did that as it was a regression from his PR.

[rushatgabhane]

no c+ pay due here 😄

[OfstadC]

Ah okay perfect! Thanks for letting me know @shubham1206agra!