[$250] Report fields - Unable to save content in text report field if there is no space at the end

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.25-3
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh05081@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings > Report fields.
3. Click Add field.
4. Create a text type report field, without initial value.
5. Click on the added text type report field.
6. Click Initial value.
7. Enter anything without space at the end of text and save it.
8. Note that the content is not saved when there is no space at the end.
9. Click Initial value.
10. Enter anything, followed by a space, and save it.
11. Note that the content is saved when there is space at the end.

Expected Result:

Content without space at the end should be saved.

Actual Result:

Content without space at the end is not saved when editing text type report field.
This issue only happens with the created text type report field, and not while the report field is being created.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6584306_1724775424979.bandicam_2024-08-28_00-10-14-839.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016970107b81b06f81
• Upwork Job ID: 1828482902901740534
• Last Price Increase: 2024-08-27
• Automatic offers:
• cretadn22 | Contributor | 103705877
• ishpaul777 | Contributor | 103705905

Issue Owner

Current Issue Owner: @ishpaul777

[melvin-bot]

Triggered auto assignment to @chiragsalian (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #wave-control

[melvin-bot]

📣 @YeGop0218! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[cretadn22]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unable to save content in text report field if there is no space at the end

What is the root cause of that problem?

App/src/pages/workspace/reportFields/ReportFieldsInitialValuePage.tsx

Line 51 in 9fbed40

ReportField.updateReportFieldInitialValue(policyID, reportFieldID, initialValue === values.initialValue ? '' : values.initialValue);

App/src/pages/workspace/reportFields/ReportFieldsInitialValuePage.tsx

Line 58 in 9fbed40

ReportField.updateReportFieldInitialValue(policyID, reportFieldID, initialValue === value ? '' : value);

initialValue === value.initialValue always be true because initialValue is updated every time the text changes

App/src/pages/workspace/reportFields/ReportFieldsInitialValuePage.tsx

Line 140 in 9fbed40

onChangeText={setInitialValue}

What changes do you think we should make in order to solve the problem?

Use WorkspaceReportFieldUtils.getReportFieldInitialValue(reportField) to check if the user has updated the old value instead of relying on the initialValue state, as WorkspaceReportFieldUtils.getReportFieldInitialValue(reportField) will always return the old value.

When the new value is similar to the old value, handle the updates as follows:

Text type: No action required.
List type: Update the initial value to an empty string.

What alternative solutions did you explore? (Optional)

[cretadn22]

The Offending PR: #47828

[chiragsalian]

Nice, your solution LGTM, how quickly can you push up a PR for this @cretadn22? Asking cause its hourly. So the sooner the better.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016970107b81b06f81

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

[cretadn22]

@chiragsalian The PR is ready soon

[melvin-bot]

📣 @cretadn22 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[ishpaul777]

Does that not require a c+?

[melvin-bot]

📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[chiragsalian]

oops i didnt mean to unassign @ishpaul777 earlier. I think that was some race condition when i added cretadn.
But yeah since this is a blocker for deploy I'm fine with skipping C+ for this.

[chiragsalian]

but hey @ishpaul777, if you are around and available to help out I'll gladly accept the help 🙂 I'd just like this to be addressed soon so it doesn't block deploy.

[ishpaul777]

yes i'll be around to help review PR :D

[chiragsalian]

CP-d a fix. Tested on staging web and it LGTM. Removing blocker label and checking it off the checklist.

[ishpaul777]

Deployed in this checklist #48221, Paydate 6 sept. Plaase help remove Reviewing label and Add Awaiting payment 🙏

[melvin-bot]

@chiragsalian @dylanexpensify @ishpaul777 @cretadn22 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[dylanexpensify]

Payment summary:

Contributor: @cretadn22 $250
Contributor+: @ishpaul777 $250

Please apply/request!

[dylanexpensify]

paid!