[$250] QBO - Sending message with Enter key shows QBO export warning pop-up

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.25-10
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp https://expensify.testrail.io/index.php?/tests/view/4896447
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• Workspace is connected to QBO.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit an expense to the workspace chat.
4. In the main chat, pay elsewhere the report.
5. Click Mark as manually entered on the expense preview in the main chat.
6. Click Mark as manually entered button again.
7. Click Yes, export again.
8. Type anything on the composer.
9. Send the message by hitting Enter.

Expected Result:

Message is sent without QBO export warning pop-up.

Actual Result:

Message is sent with QBO export warning pop-up when sending message with Enter key.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6585257_1724848121830.20240828_202416.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011edb5fb3e9d5b97a
• Upwork Job ID: 1828778510854892649
• Last Price Increase: 2024-09-11

Issue Owner

Current Issue Owner: @s77rt

[melvin-bot]

Triggered auto assignment to @nkuoch (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 1

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011edb5fb3e9d5b97a

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[mountiny]

This seems like a super specific flow so demoting and marking as external, seems like some focus trap issue

[NJ-2020]

Proposal

Please re-state the problem that we are trying to solve in this issue.

QBO - Sending message with Enter key shows QBO export warning pop-up

What is the root cause of that problem?

Inside the ExportDropdownMenu we listen if the user press the enter button

App/src/components/ReportActionItem/ExportWithDropdownMenu.tsx

Lines 101 to 106 in 5356ff8

	<ButtonWithDropdownMenu<ReportExportType>
	success={!hasIntegrationAutoSync}
	pressOnEnter
	shouldAlwaysShowDropdownMenu
	anchorAlignment={dropdownAnchorAlignment}
	onPress={(_, value) => {

Even we refresh the page the bug will still show because we listen to the user whenever the user press the enter button

What changes do you think we should make in order to solve the problem?

We will enable the pressOnEnter if the user focus on the button i.e we can use onKeyDown to the button
Or we can check if the button is not focus by using useRef

What alternative solutions did you explore? (Optional)

[s77rt]

@NJ-2020 Thanks for the proposal. Can you please elaborate your RCA? The pressOnEnter is not the only factor that's taken when capturing the enter key press.

App/src/components/Button/index.tsx

Line 160 in 2ff9f65

isActive: pressOnEnter && !shouldDisableEnterShortcut && isFocused,

[s77rt]

cc @Krishna2323 #47705 seems related

[Krishna2323]

@s77rt, yep I agree, I believe this will be also resolved after the follow up PR gets merged.

[melvin-bot]

@nkuoch, @anmurali, @s77rt Eep! 4 days overdue now. Issues have feelings too...

[s77rt]

Not overdue. Waiting on #48128

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@nkuoch, @anmurali, @s77rt Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[s77rt]

This should be fixed already. @Krishna2323 can you please confirm the same?

[melvin-bot]

@nkuoch, @anmurali, @s77rt Whoops! This issue is 2 days overdue. Let's get this updated quick!

[s77rt]

@anmurali or @nkuoch Let's close this

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@nkuoch @anmurali @s77rt this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[s77rt]

^

[trjExpensify]

@anmurali or @nkuoch Let's close this

Closing.