[Workspace Feeds] [$250] Expensify card - Unable to issue new cards to members

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.25-4
Reproducible in staging?: Y
Reproducible in production?: Can't check
Issue was found when executing this PR: #47844
Issue reported by: Applause Internal Team

Action Performed:

1. Log in with an expensifail account
2. Create a workspace and invite an existing Gmail member
3. Navigate to Workspace settings - More features
4. Enable "Expensify Card"
5. Navigate to Workspace settings - Expensify Card
6. Click on the "Issue new card" button
7. Add Regions bank with Plaid
8. Click on the "Issue new card" button again
9. Choose the bank account and member
10. Choose "Physical" or "Virtual" card
11. Set any limit type
12. Set any limit
13. Set any name
14. Click on the "Issue card" button

Expected Result:

The card should be added for the member

Actual Result:

Unable to issue new cards to members. I'm returned to the "Expensify Card" after issuing the card but it's not added for the member. Affects both the "Expensify Card" flow and a card added from the "Members" page after selecting one.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6584379_1724779087797.Members_page.mp4

Bug6584379_1724779087771.Add_card.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01daeec4f6ff832c54
• Upwork Job ID: 1831039312939789039
• Last Price Increase: 2024-09-03
• Automatic offers:
• DylanDylann | Reviewer | 103809990
• allgandalf | Contributor | 103809991

Issue Owner

Current Issue Owner: @sobitneupane

[melvin-bot]

Triggered auto assignment to @arosiclair (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 2

[arosiclair]

I found these logs for that test user which show CreateExpensifyCard failing with error 404 Business not provisioned. I think this probably doesn't need to block App deploy, but I'm not sure.

@mountiny can you take a look? cc @nkuoch since I see you authored most of CreateExpensifyCard.

[arosiclair]

Asked if this is related to the fireroom here as well

[arosiclair]

Removed the label since this looks to be behind a beta (slack convo) and assigning to @mountiny to take a look when he gets back.

[mountiny]

Thanks! I have seen this error before for some testers. Not sure yet what is leading to it as they should be provisioned when they enter the new card flow

[koko57]

@mountiny @arosiclair although nothing has changed since CreateExpensifyCard was merged let's keep in touch whether it's a BE or FE issue. I'll look into it later if it could be some problem on the FE side.

[nkuoch]

Maybe it just hasn't been implemented FE side yet?
From the video and the logs, I see that we never actually called ConfigureExpensifyCardsForPolicy.
It should have been called after adding the vbba successfully.
We shouldn't allow to call CreateExpensifyCard from the front end if the workspace hasn't been provisioned.

[koko57]

@nkuoch this was implemented, but I'll check why ConfigureExpensifyCardsForPolicy is not called, thanks!

[mountiny]

I think this might be some old policy which enabled the feature before we had this fully implemented.

@IuliiaHerets Can you confirm if you can repro this starting from scratch with a new account?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01daeec4f6ff832c54

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[melvin-bot]

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @allgandalf 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mountiny]

Alright we will need to debug this more, seems like some race condition or we skip calling some API command during the card setup

[koko57]

@mountiny can we retest it? The request cannot be triggered only when we don't have the bankAccountID. probably it occurred for the same reason we had a problem with #45729. As now we're getting the same bankAccountList object we should have all the necessary data. I cannot reproduce ConfigureExpensifyCardsForPolicy locally.

[mountiny]

Hmm seems like they have retested this just yesterday though

[mountiny]

For @kevinksullivan I could not find any API calls to the ConfigureExpensifyCardsForPolicy So we need to dig into why that would not be called for some reason

[mountiny]

@allgandalf @DylanDylann will look into this one as soon as they can to try to narrow down the rootcause here

[DylanDylann]

@mountiny I confirmed that CONFIGURE_EXPENSIFY_CARDS_FOR_POLICY isn't called

The problem: The backend doesn't return bankAccountID in bankAccountList > accountData

[mountiny]

Perfect, yeah, so the problem is different formats of the bank account ID, which is a relic issue from the past. for some API commands, we return the data straight from Auth, and for some, we modify the data shape in Web, and it's causing this mess.

I also see that the methodID is actually bankAccountID 🤦 so you can use that

[mountiny]

This should be fixed in staging now