[HOLD for payment 2025-01-13] [$250] iOS Autofill magic code not working

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.27-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @ishpaul777
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1725292622506979

Action Performed:

1. Sign in with mobile number on IOS
2. Wait to receive magic code suggestion in keyboard suggestion
3. click on suggestion

Expected Result:

Magic code pasted in Input correctly

Actual Result:

Only 1 digit of magic code pasted in Input. Last digit gets pasted in first magic code entry field

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

ScreenRecording_08-31-2024.01-04-17_1.MP4

RPReplay_Final1725303564.MP4

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021834255723519464021
• Upwork Job ID: 1834255723519464021
• Last Price Increase: 2024-09-19

Issue Owner

Current Issue Owner: @abekkala

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

@miljakljajic Whoops! This issue is 2 days overdue. Let's get this updated quick!

[miljakljajic]

https://expensify.slack.com/archives/C9YU7BX5M/p1725893743202769

[m-natarajan]

Still able to reproduce.

RPReplay_Final1725916628.MP4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021834255723519464021

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[melvin-bot]

@miljakljajic @alitoshmatov this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@miljakljajic, @alitoshmatov Eep! 4 days overdue now. Issues have feelings too...

[alitoshmatov]

Waiting for proposals

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[hannojg]

PR is ready here:

• fix: auto insert OTP not working #54253

[abekkala]

Not yet merged.

NOTE:

I will be ooo until Monday - Jan 06. I will still be periodically checking in on GHs in the event this one comes up for payment before Jan 06.

[hannojg]

PR with a fix has been merged. A separate issue has been identified while working on this one:

• At magic code screen, the keyboard doesn't switch to the numeric input and is "unfocused" #54658

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.80-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: auto insert OTP not working #54253

If no regressions arise, payment will be issued on 2025-01-13. 🎊

For reference, here are some details about the assignees on this issue:

• @hannojg does not require payment (Contractor)
• @allroundexperts requires payment through NewDot Manual Requests
• @ishpaul777 requires payment (Needs manual offer from BZ)

[melvin-bot]

@allroundexperts @abekkala @allroundexperts The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[abekkala]

PAYMENT SUMMARY FOR JAN 13

• Fix: @hannojg - no payment needed (margelo)
• PR Review: @allroundexperts [$250, if no regressions] payment via NewDot
  please complete the checklist above

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @hannojg is from an agency-contributor and not due payment
• Reviewer: @allroundexperts owed $250 via NewDot

BugZero Checklist (@abekkala)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1834255723519464021/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[abekkala]

@allroundexperts can you please compelte the checklist above?

[allroundexperts]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: N/A (There isn't a single PR responsible for this. It was an edge case that wasn't discovered until now)

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue: https://github.com/Expensify/Expensify/issues/461097

Regression Test Proposal

Precondition:

• On iOS native, make sure you have the mail app installed.
• You must be logged in to the mail app using the email that has an Expensify account.

Test:

1. Open the login screen on a native iOS device
2. Enter your email address (which you've added to your iOS Mail app)
3. Once redirected to the OTP screen, open your mail app and wait for the OTP to arrive
4. Go back to NewDot, wait for mail code to be suggested above the keyboard
5. Click on the suggested OTP code to auto insert it
6. Make sure the OTP code gets inserted and the user is logged in

Do we agree 👍 or 👎

[abekkala]

@allroundexperts can you complete that checklist template?

[allroundexperts]

@abekkala All done!

[abekkala]

PAYMENT SUMMARY

• Fix: @hannojg - no payment needed (margelo)
• PR Review: @allroundexperts [$250] payment via NewDot