[HOLD for payment 2024-09-10] [$250] iOS - Composer - Add attachment modal is hidden behind the keyboard

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.28-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Launch New Expensify app
2. Go to any chat
3. Focus on the composer (important)
4. Tap +
5. Tap Add attachment

Expected Result:

Add attachment modal will not be hidden behind the keyboard

Actual Result:

Add attachment modal is hidden behind the keyboard

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6591208_1725321471394.ScreenRecording_09-03-2024_07-55-51_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01929e53bf6e5a45ee
• Upwork Job ID: 1831044805586591004
• Last Price Increase: 2024-09-03
• Automatic offers:
• ishpaul777 | Contributor | 103803636

Issue Owner

Current Issue Owner: @stephanieelliott

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @danieldoglas (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[danieldoglas]

It looks like a glitch; I can't simulate that after several tries.

RPReplay_Final1725388834.MP4

[roryabraham]

@danieldoglas looks like you're testing on iOS web, not iOS native

[melvin-bot]

Current assignee @stephanieelliott is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

Current assignee @danieldoglas is eligible for the DeployBlockerCash assigner, not assigning anyone new.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01929e53bf6e5a45ee

[ishpaul777]

i found the Root cause :

Here when we close all modals

App/src/components/PopoverMenu.tsx

Lines 143 to 146 in 227aa13

	Modal.close(() => {
	onItemSelected(selectedItem, index);
	selectedItem.onSelected?.();
	});

this onClose is triggered

App/src/components/PopoverMenu.tsx

Line 232 in 227aa13

onClose();

which triggers this which triggers restoreKeyboardState here

App/src/pages/home/report/ReportActionCompose/AttachmentPickerWithMenuItems.tsx

Line 312 in 227aa13

onClose={onPopoverMenuClose}

Solution:
we have this case covered before in onItemSelected, now its just not called before the modal close

App/src/pages/home/report/ReportActionCompose/ReportActionCompose.tsx

Lines 273 to 275 in 227aa13

	const onItemSelected = useCallback(() => {
	isKeyboardVisibleWhenShowingModalRef.current = false;
	}, []);

so we have to modify this

App/src/components/PopoverMenu.tsx

Lines 143 to 146 in 227aa13

	Modal.close(() => {
	onItemSelected(selectedItem, index);
	selectedItem.onSelected?.();
	});

to

            onItemSelected(selectedItem, index);
            Modal.close(() => {
                selectedItem.onSelected?.();
            });

so onItemSelected is called before we close modal just like before

[danieldoglas]

@ishpaul777 can you spin up a PR for that?

[melvin-bot]

📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[situchan]

Looks like regression from #47991

[roryabraham]

cherry-picking the fix here: https://github.com/Expensify/App/actions/runs/10691504641

[roryabraham]

Verified this is fixed on staging ✅

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.28-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [FIX] "iOS - Composer - Add attachment modal is hidden behind the keyboard" #48510

If no regressions arise, payment will be issued on 2024-09-10. 🎊

For reference, here are some details about the assignees on this issue:

• @parasharrajat requires payment through NewDot Manual Requests
• @ishpaul777 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat / @ishpaul777] The PR that introduced the bug has been identified. Link to the PR:
• [@parasharrajat / @ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@parasharrajat / @ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@parasharrajat / @ishpaul777] Determine if we should create a regression test for this bug.
• [@parasharrajat / @ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[danieldoglas]

Removing @parasharrajat

[stephanieelliott]

Summarizing payment on this issue:

• Contributor: @ishpaul777 $250 via Upwork -- PAID
• Contributor+: n/a internal

Upwork job is here: https://www.upwork.com/jobs/~01929e53bf6e5a45ee