-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workspace Chat Details Page Notification Preferences Picker is Broken #4849
Comments
Triggered auto assignment to @sophiepintoraetz ( |
@shawnborton I think we are okay with this UI, spacing between Kindly help me with the following, currently we have the following options in, If we want to change the options list here, let me know new options name & translations copy for new options relevant value hint text copy. |
The spacing looks great. But actually maybe we don't need the hint text, maybe we can just shorten the label to be something like "Notify me about new messages"? |
So I think we are fine with existing Options, Will update the hint text to "Notify me about new messages", help me with cc: @shawnborton |
All looking good - great detail on the write up, Santhosh. |
Triggered auto assignment to @nkuoch ( |
@sophiepintoraetz why it's not been external? |
Is it because just a copy change? |
Triggered auto assignment to @trjExpensify ( |
Hey @Santhosh-Sellavel - looks like this may have been missed on our end but I've applied the label now, so @trjExpensify will suss out payment for the reporting of the issue. Thanks! |
Just coming back from OoO. @Santhosh-Sellavel I've created the Upwork job here. Can you apply please, and then I'll pay it and close this issue out. |
@trjExpensify Applied! |
Perfect. Offer sent 👍 |
@trjExpensify Accepted, thanks! 🥳 |
Awesome, paid. Going to close this out now, thanks @Santhosh-Sellavel! |
🚀 Deployed to production by @roryabraham in version: 1.0.90-2 🚀
|
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
announce
if workspace channel or room doesn't appear.announce
chat from search resultsExpected Result:
I don't know exactly. IMO Like this short picker label and description below.
![Screenshot 2021-08-26 at 10 09 39 AM](https://user-images.githubusercontent.com/85645967/130901630-a260761c-6b2a-4005-8b9c-98f80a116ab3.png)
Actual Result:
Workaround:
Can the user still use Expensify without this being fixed? Technically Yes, But it's should be fixed as soon as possible because the component looks broken
Platform:
Where is this issue occurring? ALL Platforms
Suggestion or Proposal
Need's input from design team how it's intended look, cc: @shawnborton.
IMO is it should look similar to as it is in
preferences page
(Attached Image in Expected Result)Proposal post triage & discussion.
Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: