Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace Chat Details Page Notification Preferences Picker is Broken #4849

Closed
Santhosh-Sellavel opened this issue Aug 26, 2021 · 18 comments
Closed
Assignees
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement. Reviewing Has a PR in review

Comments

@Santhosh-Sellavel
Copy link
Collaborator

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to New Expensify
  2. Click +
  3. New workspace
  4. Invite some users to the workspace
  5. Now go to the report list (Chat list)
  6. Press CMD + K or click on the search icon
  7. Enter announce if workspace channel or room doesn't appear.
  8. Open announce chat from search results
  9. Click on the chat header
  10. Details page will open
  11. Look at notification preferences picker its broken

Expected Result:

I don't know exactly. IMO Like this short picker label and description below.
Screenshot 2021-08-26 at 10 09 39 AM

Actual Result:

Screenshot_1629952581
Screenshot 2021-08-26 at 10 00 31 AM

Workaround:

Can the user still use Expensify without this being fixed? Technically Yes, But it's should be fixed as soon as possible because the component looks broken

Platform:

Where is this issue occurring? ALL Platforms

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Suggestion or Proposal

Need's input from design team how it's intended look, cc: @shawnborton.
IMO is it should look similar to as it is inpreferences page(Attached Image in Expected Result)

Proposal post triage & discussion.

Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:

View all open jobs on GitHub

@Santhosh-Sellavel Santhosh-Sellavel added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels Aug 26, 2021
@MelvinBot
Copy link

Triggered auto assignment to @sophiepintoraetz (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Aug 26, 2021
@Santhosh-Sellavel Santhosh-Sellavel changed the title Workspace Chat Details Page Notification Preference Picker is Broken Workspace Chat Details Page Notification Preferences Picker is Broken Aug 26, 2021
@shawnborton
Copy link
Contributor

For this one, I think we should do something like this where we have a simple label + value, then hint text below the UI control that explains what the selection does:
image

@Santhosh-Sellavel
Copy link
Collaborator Author

@shawnborton I think we are okay with this UI, spacing between Picker and hint text is mt1 that is 4
Screenshot 2021-08-26 at 3 10 45 PM

Kindly help me with the following, currently we have the following options in,
Screenshot 2021-08-26 at 3 13 54 PM

If we want to change the options list here, let me know new options name & translations copy for new options relevant value hint text copy.
If we keep the same options as option then relevant value hint text copy with translations alone. Thanks!

@shawnborton
Copy link
Contributor

The spacing looks great. But actually maybe we don't need the hint text, maybe we can just shorten the label to be something like "Notify me about new messages"?

@Santhosh-Sellavel
Copy link
Collaborator Author

Santhosh-Sellavel commented Aug 26, 2021

So I think we are fine with existing Options, Will update the hint text to "Notify me about new messages", help me with es translations alone. Let's get it done, thanks!

cc: @shawnborton

@sophiepintoraetz
Copy link
Contributor

All looking good - great detail on the write up, Santhosh.

@sophiepintoraetz sophiepintoraetz added Engineering Improvement Item broken or needs improvement. Weekly KSv2 labels Aug 26, 2021
@MelvinBot
Copy link

Triggered auto assignment to @nkuoch (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@sophiepintoraetz sophiepintoraetz removed the Daily KSv2 label Aug 26, 2021
@sophiepintoraetz sophiepintoraetz removed their assignment Aug 26, 2021
@nkuoch nkuoch added the Reviewing Has a PR in review label Aug 27, 2021
@Santhosh-Sellavel
Copy link
Collaborator Author

@sophiepintoraetz why it's not been external?

@Santhosh-Sellavel
Copy link
Collaborator Author

Is it because just a copy change?

@botify botify closed this as completed Aug 29, 2021
@sophiepintoraetz sophiepintoraetz added the External Added to denote the issue can be worked on by a contributor label Aug 29, 2021
@MelvinBot
Copy link

Triggered auto assignment to @trjExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@MelvinBot MelvinBot added Daily KSv2 and removed Weekly KSv2 labels Aug 29, 2021
@sophiepintoraetz
Copy link
Contributor

Hey @Santhosh-Sellavel - looks like this may have been missed on our end but I've applied the label now, so @trjExpensify will suss out payment for the reporting of the issue. Thanks!

@botify
Copy link

botify commented Aug 30, 2021

🚀 Deployed to staging by @nkuoch in version: 1.0.88-3 🚀

platform result
🤖 android 🤖 cancelled 🔪
🖥 desktop 🖥 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪
🕸 web 🕸 success ✅

@trjExpensify
Copy link
Contributor

Just coming back from OoO. @Santhosh-Sellavel I've created the Upwork job here. Can you apply please, and then I'll pay it and close this issue out.

@trjExpensify trjExpensify reopened this Aug 31, 2021
@Santhosh-Sellavel
Copy link
Collaborator Author

@trjExpensify Applied!

@trjExpensify
Copy link
Contributor

Perfect. Offer sent 👍

@Santhosh-Sellavel
Copy link
Collaborator Author

@trjExpensify Accepted, thanks! 🥳

@trjExpensify
Copy link
Contributor

Awesome, paid. Going to close this out now, thanks @Santhosh-Sellavel!

@botify
Copy link

botify commented Sep 1, 2021

🚀 Deployed to production by @roryabraham in version: 1.0.90-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement. Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

7 participants