[$250] Contact method - Main email doesn't get validated after inserting magic code

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.28-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): testpayment935@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Navigate to staging.new.expensify.com
2. Sign in with a new gmail account
3. Go to contact method
4. Click on New contact method
5. Add a new account
6. After being navigated to validate main email account enter magic code and validate it

Expected Result:

After validating the main email account the GBR should disappear from the main email and the main email should now be considered as validated

Actual Result:

Main gmail account still considered to be unvalidated after getting magic code and validated using it

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6592205_1725395703195.Screen_Recording_20240903_233032_Chrome.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021831356985561814829
• Upwork Job ID: 1831356985561814829
• Last Price Increase: 2024-09-04

Issue Owner

Current Issue Owner: @mountiny

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

@lschurr FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[NJ-2020]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Contact method - Main email doesn't get validated after inserting magic code

What is the root cause of that problem?

Right here we return exit from the function if we have a pending contact meaning adding new contact

App/src/pages/settings/Profile/Contacts/ValidateCodeForm/BaseValidateCodeForm.tsx

Lines 190 to 195 in 562d7b4

	if (!!pendingContact?.contactMethod && isValidatingAction) {
	User.addNewContactMethod(pendingContact?.contactMethod, validateCode);
	return;
	}
	User.validateSecondaryLogin(loginList, contactMethod, validateCode);

What changes do you think we should make in order to solve the problem?

We can just remove the return statement

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021831356985561814829

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[lschurr]

Hi @c3024! Could you review the proposal here when you get a chance?

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Main gmail account still considered to be unvalidated after getting magic code and validated using it

What is the root cause of that problem?

I don't think this is a bug, in Step 6, we're validating the ACTION to add secondary contact, not the (main) contact itself. It's like KYC/proving you're the one who made the action before actually verifying the contact method.

I think the problem lies in the validate code prompt text that confused users, even the QA and contributors. We need to update it.

What changes do you think we should make in order to solve the problem?

Take Google for example, it just simply shows To continue, first verify it’s you:

To do that, we can modify the message in ValidateContactActionPage:

App/src/pages/settings/Profile/Contacts/ValidateContactActionPage.tsx

Line 56 in ac51c3b

messages={{0: translate('contacts.enterMagicCode', {contactMethod: account?.primaryLogin ?? ''})}}

[mountiny]

Their will require backend change to work

[mountiny]

MAking this weekly as its not that critical

[melvin-bot]

@lschurr, @mountiny, @c3024 Huh... This is 4 days overdue. Who can take care of this?

[mountiny]

This is not overdue

[trjExpensify]

What changes do we need to make here?

If you're adding a secondary login with an unvalidated primary, and we prompt to "prove it's you" by entering a magic code, we should validate the primary?

[mountiny]

focusing on higher priorities still

[mountiny]

low

[mountiny]

same

[mountiny]

@c3024, could you please retest if this is still happening? I think we might have made some changes to this flow

[c3024]

@mountiny

Still happening.

1. GBR remains.
2. Clicking on the contact method, even after verifying once through "Add Contact Method" flow, asks for magic code.

primaryMagicCode.mp4

[mountiny]

@c3024 thanks for verifying

[kavimuru]

GBR is not displayed anymore as per this PR #49004

Screen_Recording_20241111_172256_Chrome.mp4

[c3024]

I am still seeing the GBR now on staging. 🤔

Screen.Recording.2024-11-12.at.7.45.52.PM.mov

The GBR is not there on signup but some data from backend seems to make the GBR appear after validating the primary account through the "Add secondary contact method" flow.

[mountiny]

low

[mountiny]

still in progress, been focusing on app deploy this week

[mountiny]

low