Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-09-23] [$250] [Workspace feeds] update copy in card name step of issue card flow #48733

Closed
kevinksullivan opened this issue Sep 6, 2024 · 24 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@kevinksullivan
Copy link
Contributor

kevinksullivan commented Sep 6, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Slack conversation: https://expensify.slack.com/archives/C036QM0SLJK/p1725488109420779

Action Performed:

  1. Sign up with gmail account added to Workspace feeds beta
  2. Enable Expensify Card in more features
  3. Complete setup using credentials from option 3 in the SO
  4. Go through issue card flow, land on card name step

Expected Result:

Copy should say: Make it unique enough to tell apart from other cards. Specific use cases are even better!

  • Translation: Hazlo lo suficientemente único para distinguirla de otras tarjetas. ¡Los casos de uso específicos son aún mejores!

Actual Result:

Copy is currently wrong

image

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021832428586783897931
  • Upwork Job ID: 1832428586783897931
  • Last Price Increase: 2024-09-07
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @anmurali
Copy link

melvin-bot bot commented Sep 6, 2024

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@kevinksullivan kevinksullivan moved this to Release 2.5: SuiteWorld (Sept 9th) in [#whatsnext] #wave-collect Sep 6, 2024
@gijoe0295
Copy link
Contributor

gijoe0295 commented Sep 6, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

Copy is currently wrong

What is the root cause of that problem?

Copy update

What changes do you think we should make in order to solve the problem?

Update this copy:

giveItNameInstruction: 'Make it unique enough to tell apart from the other. Specific use cases are even better!',

giveItNameInstruction: 'Hazlo lo suficientemente único como para distinguirlo de los demás. Los casos de uso específicos son aún mejores.',

@mountiny
Copy link
Contributor

mountiny commented Sep 7, 2024

Sorry handling this with the team

@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label Sep 7, 2024
@melvin-bot melvin-bot bot changed the title [Workspace feeds] update copy in card name step of issue card flow [$250] [Workspace feeds] update copy in card name step of issue card flow Sep 7, 2024
Copy link

melvin-bot bot commented Sep 7, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021832428586783897931

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 7, 2024
Copy link

melvin-bot bot commented Sep 7, 2024

Current assignees @allroundexperts and @ishpaul777 are eligible for the External assigner, not assigning anyone new.

@abhinaybathina
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

In the issue card flow, the instructions for making a unique name is not clear.

What is the root cause of that problem?

Incorrect locales in both en and es files

What changes do you think we should make in order to solve the problem?

We need to update the giveItNameInstruction locale value with the updated text

What alternative solutions did you explore? (Optional)

Copy link

melvin-bot bot commented Sep 7, 2024

📣 @abhinaybathina! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@abhinaybathina
Copy link
Contributor

Contributor details
Your Expensify account email: abhinaybathina2@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~0168e425032efb76e6

Copy link

melvin-bot bot commented Sep 7, 2024

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@abhinaybathina
Copy link
Contributor

Can you please assign this job to me?

@ishpaul777
Copy link
Contributor

Hey @abhinaybathina, This issue is already assigned, there's many more issues that are open for proposal https://github.com/Expensify/App/issues?q=is%3Aopen+is%3Aissue+label%3A%22Help+Wanted%22

@abhinaybathina
Copy link
Contributor

Okay, thanks! I'll check the others

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Sep 8, 2024
@trjExpensify trjExpensify moved this from Release 2.5: SuiteWorld (Sept 9th) to Polish in [#whatsnext] #wave-collect Sep 9, 2024
@ishpaul777
Copy link
Contributor

Deployed 2 weeks ago with this checklist #48791 (comment), should be ready for payment

@mountiny mountiny added Daily KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Reviewing Has a PR in review Weekly KSv2 labels Sep 23, 2024
@mountiny mountiny changed the title [$250] [Workspace feeds] update copy in card name step of issue card flow [HOLD for payment 2024-09-23] [$250] [Workspace feeds] update copy in card name step of issue card flow Sep 23, 2024
@mountiny mountiny removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 23, 2024
@mountiny
Copy link
Contributor

Updated! We fixed two things in this PR so $250 is appropriate.

Copy link

melvin-bot bot commented Sep 23, 2024

Payment Summary

Upwork Job

BugZero Checklist (@anmurali)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1832428586783897931/hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@melvin-bot melvin-bot bot added the Overdue label Sep 25, 2024
Copy link

melvin-bot bot commented Sep 26, 2024

@anmurali, @allroundexperts, @mountiny, @ishpaul777 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@ishpaul777
Copy link
Contributor

Not overdue, Just waiting for payment

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Daily KSv2 Overdue labels Sep 29, 2024
Copy link

melvin-bot bot commented Oct 2, 2024

@anmurali, @allroundexperts, @mountiny, @ishpaul777 Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Oct 4, 2024

@anmurali, @allroundexperts, @mountiny, @ishpaul777 Eep! 4 days overdue now. Issues have feelings too...

@ishpaul777
Copy link
Contributor

just pending payment, Melvin go away 💢

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@anmurali
Copy link

anmurali commented Oct 5, 2024

Payment Summary

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 5, 2024
@ishpaul777
Copy link
Contributor

Accpted, thanks!

@JmillsExpensify
Copy link

$250 approved for @allroundexperts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
Status: Done
Development

No branches or pull requests

9 participants