[HOLD for payment 2024-09-18] Room - Dropdown button does not update the selected member count after deleting member

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.31-0
Reproducible in staging?: Y
Reproducible in production?: N/A
Email or phone of affected tester (no customers): 9.0.31-0
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to room.
3. Click on the room header > Members.
4. Add two users to the room.
5. Select all members via the checkbox.
6. Click on any member (except the room owner).
7. Click Remove from chat.
8. Click Remove.

Expected Result:

The dropdown button will update the selected member count to 1.

Actual Result:

The dropdown button does not update the selected member count after deleting member.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6597775_1725902329139.20240910_003649.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @garrettmknight

[melvin-bot]

Triggered auto assignment to @johnmlee101 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[rayane-djouah]

This is coming from my PR, I will raise a follow-up PR later today
cc @paultsimura

[paultsimura]

Yeah, there was so much stuff going on in that PR that we definitely could have missed smth. Thanks @rayane-djouah

[paultsimura]

@rayane-djouah on the ReportParticipantsPage, we clear the selection when leaving the list (opening the member details page in this case). We should implement the same logic here as the original task was to make room members page behave similarly to the report members one.

@garrettmknight / @johnmlee101, the Expected Result here should be changed to:

The dropdown button gets replaced with the green "+ Invite member" button and none of the members remain selected.

[luacmartins]

This is fixed on staging. Closing since it came from a regression and no payment is due.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.31-26 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix/48801 #48806

If no regressions arise, payment will be issued on 2024-09-18. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@johnmlee101 / @luacmartins] The PR that introduced the bug has been identified. Link to the PR:
• [@johnmlee101 / @luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@johnmlee101 / @luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@johnmlee101 / @luacmartins] Determine if we should create a regression test for this bug.
• [@johnmlee101 / @luacmartins] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: