Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login - Many "get started here" messages shown after login #48960

Closed
2 of 6 tasks
IuliiaHerets opened this issue Sep 11, 2024 · 12 comments
Closed
2 of 6 tasks

Login - Many "get started here" messages shown after login #48960

IuliiaHerets opened this issue Sep 11, 2024 · 12 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Hourly KSv2 Reviewing Has a PR in review

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.32-0
Reproducible in staging?: Y
Reproducible in production?: N
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Log in to an existing account

Expected Result:

No get started message is shown

Actual Result:

Many "get started here" messages shown after login

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6599447_1726019837132!Screenshot_2024-09-11_at_4 56 58_at_night

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Sep 11, 2024
Copy link

melvin-bot bot commented Sep 11, 2024

Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Sep 11, 2024

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Sep 11, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Sep 11, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@tienifr
Copy link
Contributor

tienifr commented Sep 11, 2024

Will raise the PR soon

@tienifr
Copy link
Contributor

tienifr commented Sep 11, 2024

PR is here

@flodnv
Copy link
Contributor

flodnv commented Sep 11, 2024

Thanks @tienifr

@flodnv flodnv assigned tienifr and unassigned flodnv and isabelastisser Sep 11, 2024
@flodnv flodnv added Reviewing Has a PR in review and removed DeployBlocker Indicates it should block deploying the API labels Sep 11, 2024
@Julesssss
Copy link
Contributor

CP'd, build in progress

@trjExpensify
Copy link
Contributor

Ahh, nice. I was going to raise this one this morning after some late night testing yesterday:

image

...but I couldn't reproduce it just now coz' we've CP'd a fix. Thanks! 😅

@Julesssss
Copy link
Contributor

Mirroring the comment here on the PR for visibility:

CP was successful, though the 'Post a Github comment' step failed due to an infinite loop.

@flodnv please verify the fix on staging 9.0.32-1 and then check it off the checklist, thanks.

@flodnv
Copy link
Contributor

flodnv commented Sep 11, 2024

Why me? We usually ask #qa. I will ask them: https://expensify.slack.com/archives/C9YU7BX5M/p1726056732400039

@kavimuru
Copy link

Not repro with existing account.

web.mp4

@flodnv
Copy link
Contributor

flodnv commented Sep 11, 2024

Cool, this is resolved, thanks @tienifr

@flodnv flodnv closed this as completed Sep 11, 2024
@luacmartins luacmartins removed the DeployBlockerCash This issue or pull request should block deployment label Sep 11, 2024
@dangrous dangrous mentioned this issue Sep 24, 2024
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Hourly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

8 participants