Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace Feeds] App crashes after enabling Expensify Card #49147

Closed
6 tasks done
IuliiaHerets opened this issue Sep 13, 2024 · 17 comments
Closed
6 tasks done

[Workspace Feeds] App crashes after enabling Expensify Card #49147

IuliiaHerets opened this issue Sep 13, 2024 · 17 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.34-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace settings.
  3. Go to More features.
  4. Enable Expensify Card.

Expected Result:

App will not crash.

Actual Result:

App crashes after enabling Expensify Card.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1309.txt

Bug6601797_1726194038264.crahs.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Sep 13, 2024
Copy link

melvin-bot bot commented Sep 13, 2024

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Sep 13, 2024

Triggered auto assignment to @jasperhuangg (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Sep 13, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Sep 13, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@koko57
Copy link
Contributor

koko57 commented Sep 13, 2024

I can look at this, as I worked on EC
cc @trjExpensify @mountiny but should it be a deploy blocker? It's not in beta anymore?

@VickyStash
Copy link
Contributor

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

@VickyStash
Copy link
Contributor

The app crashes with the next error:
image

'cards_-1_Expensify Card' key can't be changed to 'cards_18317771_Expensify Card'. useOnyx() only supports dynamic keys if they are both collection member keys from the same collection e.g. from 'collection_id1' to 'collection_id2'.

It looks like we have the similar issue opened related to useOnyx crash: Investigate useOnyx crash when changing policy_-1 key to policy__FAKE_

@twisterdotcom
Copy link
Contributor

@mountiny - can we just assign @VickyStash or @koko57 here? Definitely feels like a blocker. cc @kevinksullivan

@trjExpensify
Copy link
Contributor

It's still in beta. 👍

@trjExpensify trjExpensify moved this to Release 2: Summer 2024 (Aug) in [#whatsnext] #wave-collect Sep 13, 2024
@mountiny mountiny assigned mountiny and unassigned jasperhuangg Sep 13, 2024
@trjExpensify trjExpensify changed the title Expensify Card - App crashes after enabling Expensify Card [Workspace Feeds] App crashes after enabling Expensify Card Sep 13, 2024
@luacmartins
Copy link
Contributor

If this is on a beta, I'll remove the blocker

@luacmartins luacmartins added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Sep 13, 2024
@VickyStash
Copy link
Contributor

The PR which fixes the crash is opened for the review: #49173

@VickyStash
Copy link
Contributor

I'm going to be OOO Sept 14-22, in case the PR won't be merged @koko57 will take care of it.

@mountiny
Copy link
Contributor

The fix worked well, merged it

Copy link

melvin-bot bot commented Sep 14, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@mountiny
Copy link
Contributor

The onyx PR was merged so now @fabioh8010 will test the onyx bump on this bug

@fabioh8010 fabioh8010 mentioned this issue Sep 16, 2024
50 tasks
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Sep 16, 2024
@trjExpensify
Copy link
Contributor

Any reason this is still open?

@twisterdotcom
Copy link
Contributor

Do I need to pay out @s77rt?

@trjExpensify
Copy link
Contributor

I think that was handled in the other issue for Fabio's PR.

The PR for this issue didn't get C+: #49173

@github-project-automation github-project-automation bot moved this from Release 2: Summer 2024 (Aug) to Done in [#whatsnext] #wave-collect Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2
Projects
Status: Done
Development

No branches or pull requests

8 participants