[$250] [Workspace Feeds] Copied content & LHN preview do not follow "x added shipping details" message

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.34-1
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Issue was found when executing this PR: #48775
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• User is assigned a physical card.
• User does not have personal details.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Click Add shipping details.
4. Complete the flow.
5. Right click on the system message "x added shipping details" > Copy to clipboard.
6. Paste the system message.
7. Note that the copied content and LHN preview are not the same as the system message.

Expected Result:

The copied content and LHN preview will be the same as the system message.

Actual Result:

The copied content and LHN preview are not the same as the system message.
The same goes for thread header for the system message.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6601798_1726194040921.20240913_062404.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021834508189358735905
• Upwork Job ID: 1834508189358735905
• Last Price Increase: 2024-09-13
• Automatic offers:
• ishpaul777 | Reviewer | 103942798
• allgandalf | Contributor | 103945830

Issue Owner

Current Issue Owner: @ishpaul777

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @Gonals (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 2

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021834508189358735905

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

[Gonals]

External bug! It'd be nice to solve it soon, but I don't think we need to block deploy on it.

[koko57]

I'm Agata from Callstack, I worked on the cards, I can check this issue

[ishpaul777]

@Gonals is this still a hourly priorty or can be moved to daily ?

[melvin-bot]

📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[jliexpensify]

Assigned @koko57 , removed Hourly cc @Gonals

[koko57]

I started looking at the issue - just one thing that I need to clarify:
scenario: User A (with shipping address) issues a physical card for User B (no shipping address)
User B gets this message

shouldn't User B get CARDMISSINGADDRESS message? Are we shipping the card to the admin?

cc @mountiny @MariaHCD

EDIT: I also get this message when User B issues card for User A (the other way around) so I'm a bit confused 🤔

[koko57]

ok, seems like we didn't cover generating LHN alternate text with taking into account if user adds his details or not. I will prepare a PR for that

[koko57]

maybe we should update message text from the BE - now it should be shipping address not mailing address

[melvin-bot]

📣 @allgandalf 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[koko57]

PR opened #49177

Can we use display name instead of handle in LHN, copied message and Report Screen header?

[mountiny]

Thanks for a quick worked, reviewed the PR and requested some small changes

[koko57]

@mountiny changes applied

[allgandalf]

PR was deployed to production 3 days ago

[mountiny]

I believe this was all handled with the project team so we can close the issue