[Search v2.3] - Saved filter tool tip is hard to read on dark theme

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.35-0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Email or phone of affected tester (no customers): nathanmulugetatesting+1482@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition: App theme should be in dark mode.

1. Navigate to staging.new.expensify.com
2. Navigate to search
3. Click on filter
4. Setup any filter and save it

Expected Result:

The tooltip is easily readable

Actual Result:

The tooltip is hard to read on dark theme

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6603169_1726291858246.bandicam_2024-09-14_08-26-44-191.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #wave-control

[melvin-bot]

Triggered auto assignment to @francoisl (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[gijoe0295]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The tooltip is hard to read on dark theme

What is the root cause of that problem?

We're using text color for the tooltip:

App/src/pages/Search/SearchTypeMenu.tsx

Line 145 in 2dc08e9

<Text style={[styles.ml1, styles.textLabel]}>{translate('search.saveSearchTooltipText')}</Text>

App/src/styles/index.ts

Lines 376 to 377 in 14c8409

	textLabel: {
	color: theme.text,

What changes do you think we should make in order to solve the problem?

Use quickActionTooltipSubtitle style which contains textDark color:

App/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx

Line 206 in ee12dfd

<Text style={styles.quickActionTooltipSubtitle}>{translate('quickAction.tooltip.subtitle')}</Text>

App/src/styles/index.ts

Lines 3910 to 3913 in 14c8409

	quickActionTooltipSubtitle: {
	fontSize: variables.fontSizeLabel,
	color: theme.textDark,
	},

[ishpaul777]

offending PR #48566, cc @luacmartins @lakchote

[luacmartins]

PR here

[luacmartins]

Fixed in staging