Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Category CSV - Max Expense Amount in downloaded CSV displays amount without decimal point #49294

Closed
6 tasks done
IuliiaHerets opened this issue Sep 16, 2024 · 15 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Sep 16, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.35-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

  • Rules are enabled.
  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Categories.
  3. Click on any category.
  4. Click Flag amounts over.
  5. Enter amount with decimals (12.34).
  6. Save it.
  7. Dismiss RHP.
  8. Click 3-dot menu > Download CSV.
  9. Open the file.

Expected Result:

Max Expense Amount field in the downloaded CSV should display the amount correctly with decimal point.

Actual Result:

Max Expense Amount field in the downloaded CSV displays the amount without decimal point.
When the same category list is downloaded on Old Dot, it does show the amount with decimal point correctly.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6604536_1726419076572.20240916_004054.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021836046116299332518
  • Upwork Job ID: 1836046116299332518
  • Last Price Increase: 2024-09-17
Issue OwnerCurrent Issue Owner: @mollfpr
@IuliiaHerets IuliiaHerets added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 16, 2024
Copy link

melvin-bot bot commented Sep 16, 2024

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@IuliiaHerets
Copy link
Author

@joekaufmanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@joekaufmanexpensify
Copy link
Contributor

Reproduced

@joekaufmanexpensify
Copy link
Contributor

cc @marcaaron for this one too, as I think this is also related to the expense rules doc

@joekaufmanexpensify joekaufmanexpensify added the External Added to denote the issue can be worked on by a contributor label Sep 17, 2024
@melvin-bot melvin-bot bot changed the title Category CSV - Max Expense Amount in downloaded CSV displays amount without decimal point [$250] Category CSV - Max Expense Amount in downloaded CSV displays amount without decimal point Sep 17, 2024
Copy link

melvin-bot bot commented Sep 17, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021836046116299332518

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 17, 2024
Copy link

melvin-bot bot commented Sep 17, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

@marcaaron
Copy link
Contributor

I'm not familiar with that CSV export feature. We should maybe tag whoever worked on that one?

I'll confirm the backend is working correctly for this in the meantime.

@marcaaron
Copy link
Contributor

So, I think it's indirectly related. There's nothing wrong with the data. We just need to be converting the "cents" values back into "dollars" before exporting to the CSV. Should be an easy fix for whoever knows how this works already.

@marcaaron
Copy link
Contributor

Seems like this issue is where this feature was implemented @rlinoz maybe can help take a look since I think the backend is where this change would need to happen if I'm understanding the problem correctly.

@marcaaron marcaaron added Internal Requires API changes or must be handled by Expensify staff and removed External Added to denote the issue can be worked on by a contributor labels Sep 18, 2024
@joekaufmanexpensify
Copy link
Contributor

Got it, sounds good. Thanks Marc!

@rlinoz
Copy link
Contributor

rlinoz commented Sep 18, 2024

Marc is right, I will take a look!

@joekaufmanexpensify
Copy link
Contributor

Sweet. TY!

@joekaufmanexpensify
Copy link
Contributor

PR(s) in review

@melvin-bot melvin-bot bot added the Overdue label Sep 20, 2024
@joekaufmanexpensify joekaufmanexpensify added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors Overdue labels Sep 20, 2024
@joekaufmanexpensify
Copy link
Contributor

Web PR merged. Second auth PR held on web PR's being deployed

@rlinoz
Copy link
Contributor

rlinoz commented Sep 27, 2024

This is in prod now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2
Projects
Status: Done
Development

No branches or pull requests

5 participants