-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] Category CSV - Max Expense Amount in downloaded CSV displays amount without decimal point #49294
Comments
Triggered auto assignment to @joekaufmanexpensify ( |
@joekaufmanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
Reproduced |
cc @marcaaron for this one too, as I think this is also related to the expense rules doc |
Job added to Upwork: https://www.upwork.com/jobs/~021836046116299332518 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr ( |
I'm not familiar with that CSV export feature. We should maybe tag whoever worked on that one? I'll confirm the backend is working correctly for this in the meantime. |
So, I think it's indirectly related. There's nothing wrong with the data. We just need to be converting the "cents" values back into "dollars" before exporting to the CSV. Should be an easy fix for whoever knows how this works already. |
Seems like this issue is where this feature was implemented @rlinoz maybe can help take a look since I think the backend is where this change would need to happen if I'm understanding the problem correctly. |
Got it, sounds good. Thanks Marc! |
Marc is right, I will take a look! |
Sweet. TY! |
PR(s) in review |
Web PR merged. Second auth PR held on web PR's being deployed |
This is in prod now |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.35-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team
Action Performed:
Precondition:
Expected Result:
Max Expense Amount field in the downloaded CSV should display the amount correctly with decimal point.
Actual Result:
Max Expense Amount field in the downloaded CSV displays the amount without decimal point.
When the same category list is downloaded on Old Dot, it does show the amount with decimal point correctly.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6604536_1726419076572.20240916_004054.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @mollfprThe text was updated successfully, but these errors were encountered: