[$250] Task – App crashes when click on assignee in existing task #49514

IuliiaHerets · 2024-09-20T08:47:08Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.0.39-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4989792
Email or phone of affected tester (no customers): applausetester+jpcategory_2@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Go to https://staging.new.expensify.com/
Log in
Open any chat
Create a task without assignee
Open task details and click on assignee

Expected Result:

Assignee list opens

Actual Result:

App crashes

Workaround:

Unknown

Platforms:

Screenshots/Videos

2009.txt

Bug6609721_1726820372331.Assignee_crash.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021838194512143553982
Upwork Job ID: 1838194512143553982
Last Price Increase: 2024-09-23
Automatic offers:

jjcoffee | Reviewer | 104086587
nkdengineer | Contributor | 104086588

melvin-bot · 2024-09-20T08:47:17Z

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot · 2024-09-20T08:47:18Z

Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

github-actions · 2024-09-20T08:47:24Z

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

huult · 2024-09-20T09:00:41Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes when click on assignee in existing task

What is the root cause of that problem?

Use 'report' before initialization

App/src/pages/tasks/TaskAssigneeSelectorModal.tsx

Line 127 in 4c9a3fb

if (report && !ReportUtils.isTaskReport(report)) {

What changes do you think we should make in order to solve the problem?

Delay using the report until the report is complete.

// .src/pages/tasks/TaskAssigneeSelectorModal.tsx#L127
    const report: OnyxEntry<Report> = useMemo(() => {
        if (!route.params?.reportID) {
            return;
        }

+        InteractionManager.runAfterInteractions(() => {
+            requestAnimationFrame(() => {
                if (report && !ReportUtils.isTaskReport(report)) {
                    Navigation.isNavigationReady().then(() => {
                        Navigation.dismissModal(report.reportID);
                    });
                }
+            });
+        });

        return reports?.[`${ONYXKEYS.COLLECTION.REPORT}${route.params?.reportID}`];
    }, [reports, route]);

POC

Screen.Recording.2024-09-20.at.16.04.35.mp4

nkdengineer · 2024-09-20T09:05:14Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes

What is the root cause of that problem?

The report is used before it's initialize

App/src/pages/tasks/TaskAssigneeSelectorModal.tsx

Lines 123 to 129 in 4c9a3fb

    
           const report: OnyxEntry<Report> = useMemo(() => { 
        
               if (!route.params?.reportID) { 
        
                   return; 
        
               } 
        
               if (report && !ReportUtils.isTaskReport(report)) { 
        
                   Navigation.isNavigationReady().then(() => { 
        
                       Navigation.dismissModal(report.reportID);

What changes do you think we should make in order to solve the problem?

Update this to get the report data from reports to check it's task report or not

const report: OnyxEntry<Report> = useMemo(() => {
    if (!route.params?.reportID) {
        return;
    }
    const reportOnyx = reports?.[`${ONYXKEYS.COLLECTION.REPORT}${route.params?.reportID}`];
    if (reportOnyx && !ReportUtils.isTaskReport(reportOnyx)) {
        Navigation.isNavigationReady().then(() => {
            Navigation.dismissModal(reportOnyx.reportID);
        });
    }
    return reports?.[`${ONYXKEYS.COLLECTION.REPORT}${route.params?.reportID}`];
}, [reports, route]);

What alternative solutions did you explore? (Optional)

Or we can move the navigate logic to another useEffect

const report: OnyxEntry<Report> = useMemo(() => {
    if (!route.params?.reportID) {
        return;
    }
    return reports?.[`${ONYXKEYS.COLLECTION.REPORT}${route.params?.reportID}`];
}, [reports, route]);

useEffect(() => {
    if (report && !ReportUtils.isTaskReport(report)) {
        Navigation.isNavigationReady().then(() => {
            Navigation.dismissModal(report.reportID);
        });
    }
}, [report]);

flodnv · 2024-09-20T09:54:26Z

Why did this just start happening upon this deploy? What PR caused this?

nkdengineer · 2024-09-20T11:00:21Z

@flodnv Maybe it is caused by #48325. I tried to revert to the latest commit in production and install node-module again and the bug didn't happen. The bug started happening when I reverted to the first different between production and staging and re-install node-module again.

grgia · 2024-09-20T12:59:36Z

This is from #49241

See slack thread: https://expensify.slack.com/archives/C01GTK53T8Q/p1726837086718439?thread_ts=1726822044.310019&cid=C01GTK53T8Q

grgia · 2024-09-20T14:23:13Z

Updated #49241 cc @luacmartins

rayane-djouah · 2024-09-20T16:59:34Z

Updated #49241 cc @luacmartins

This is not the offending PR. I tried reverting it locally, and I'm still able to reproduce the bug.

flodnv · 2024-09-23T11:11:01Z

@flodnv Maybe it is caused by #48325. I tried to revert to the latest commit in production and install node-module again and the bug didn't happen. The bug started happening when I reverted to the first different between production and staging and re-install node-module again.

Thanks @nkdengineer. @rojiphil @BrtqKr can you please check if #48325 caused this?

BrtqKr · 2024-09-23T12:25:52Z

@flodnv, I don't think this would be related. Seems like accessing report from task is making this work

    const report: OnyxEntry<Report> = useMemo(() => {
        if (!route.params?.reportID) {
            return;
        }
        if (task?.report && !ReportUtils.isTaskReport(task?.report)) {
            Navigation.isNavigationReady().then(() => {
                Navigation.dismissModal(task?.report?.reportID);
            });
        }
        return reports?.[`${ONYXKEYS.COLLECTION.REPORT}${route.params?.reportID}`];
    }, [reports, route]);

currently, the memo is accessing itself and it seems to be the reason, why this bug is occurring, but this is quite surprising because it's been working like this for a while somehow

    const report: OnyxEntry<Report> = useMemo(() => {
        if (!route.params?.reportID) {
            return;
        }
        if (report && !ReportUtils.isTaskReport(report)) {
            Navigation.isNavigationReady().then(() => {
                Navigation.dismissModal(report.reportID);
            });
        }
        return reports?.[`${ONYXKEYS.COLLECTION.REPORT}${route.params?.reportID}`];
    }, [reports, route]);

flodnv · 2024-09-23T12:31:28Z

Right, it is strange. I assigned you @nkdengineer

melvin-bot · 2024-09-23T12:31:52Z

📣 @jjcoffee 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

melvin-bot · 2024-09-23T12:31:55Z

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

nkdengineer · 2024-09-23T12:32:50Z

Thanks, will raise the PR soon.

nkdengineer · 2024-09-23T14:16:16Z

@jjcoffee The PR is here

cc @flodnv

flodnv · 2024-09-23T15:03:31Z

Thanks!

alexpensify · 2024-09-23T17:22:34Z

Awesome, now we wait for this one to go to Prouduction.

isagoico · 2024-09-23T19:39:35Z

Retest was a pass 🎉

Recording.2024-09-23.115241.mp4

Checking it off the list.

alexpensify · 2024-09-30T22:15:35Z

Flagging that automation failed, and it was deployed to production on 09-24.

alexpensify · 2024-10-02T21:49:42Z

Ugh, automation failed and the payment date should have been yesterday. I'll work on the payment process tomorrow.

jjcoffee · 2024-10-03T07:47:46Z

The PR that introduced the bug has been identified. Link to the PR: I wasn't able to identify an offending PR
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug. Yes - if one doesn't already exist
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Open any chat
Create a task without an assignee
Open task details and click on assignee
Verify that the assignee page appears

Do we agree 👍 or 👎

luacmartins · 2024-10-03T13:52:06Z

I think this will be caught during regular regression tests, since we have many tests on tasks.

alexpensify · 2024-10-04T21:55:52Z

Payouts due: 10-01-2024

Contributor: $250 @nkdengineer
Contributor+: $250 @jjcoffee

Upwork job is here.

alexpensify · 2024-10-04T22:18:17Z

Closing - I believe that I sent the payment via Upwork, but something looks off in Upwork. Please reply if you didn't get the payment and I'll fund the new job I sent your way. I'll return later to complete the regression test.

jjcoffee · 2024-10-07T07:47:22Z

@alexpensify I didn't receive any payment, just the notification that the contract has ended and weirdly another about accepting an offer (I've accepted this).

nkdengineer · 2024-10-07T15:39:33Z

@alexpensify Same for me, the job just closed without payment. I accepted the new 2nd offer though, it can be paid out there.

alexpensify · 2024-10-07T16:45:56Z

Thanks for these updates! There is an issue an Upwork that is being investigated to address the payment process. I'm going to hold until there is a fix. Convo: https://expensify.slack.com/archives/C01GTK53T8Q/p1728319262830679

alexpensify · 2024-10-08T18:04:29Z

@jjcoffee and @nkdengineer, our team figured out the Upwork bug, and I tried to complete the payment via another payment path in Upwork. Their support team is working on a permanent fix for the bug. I'd really appreciate it if you could confirm today's payment sent successfully under the new contract. Thanks!

nkdengineer · 2024-10-09T01:18:00Z

@alexpensify Yes it was sent for me 💯 Thanks!

jjcoffee · 2024-10-09T07:27:25Z

Me too, thank you!

alexpensify · 2024-10-09T15:06:16Z

Awesome, thanks for hanging in there with me. This bug is a wild one on the Upwork side.

IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Sep 20, 2024

melvin-bot bot assigned alexpensify Sep 20, 2024

melvin-bot bot assigned flodnv Sep 20, 2024

melvin-bot bot added the Daily KSv2 label Sep 20, 2024

github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Sep 20, 2024

github-actions bot mentioned this issue Sep 20, 2024

Deploy Checklist: New Expensify 2024-09-19 #49505

Closed

31 tasks

This was referenced Sep 20, 2024

[OldDot Rules Migration] Tag rules #47016

Closed

Category rules - "Approver" is enabled when "Add approvals" is still disabled in Workflows #48977

Closed

melvin-bot bot mentioned this issue Sep 20, 2024

[HOLD for payment 2024-10-04] [$250] Avoid packaging WDYR and whole LODASH in JS bundle #48978

Closed

melvin-bot bot mentioned this issue Sep 20, 2024

[HOLD for Payment 2024-08-26] Accessing one expense reports from search opening transaction view instead of report view #45408

Closed

6 tasks

melvin-bot bot added the Overdue label Sep 23, 2024

melvin-bot bot removed the Overdue label Sep 23, 2024

flodnv assigned nkdengineer Sep 23, 2024

flodnv added the External Added to denote the issue can be worked on by a contributor label Sep 23, 2024

nkdengineer mentioned this issue Sep 23, 2024

fix app crashes when opening task assignee page #49604

Merged

50 tasks

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Sep 23, 2024

This was referenced Sep 25, 2024

Deploy Checklist: New Expensify 2024-09-24 #49662

Closed

Deploy Checklist: New Expensify 2024-09-27 #49855

Closed

jasperhuangg removed the DeployBlockerCash This issue or pull request should block deployment label Sep 30, 2024

alexpensify closed this as completed Oct 4, 2024

alexpensify reopened this Oct 8, 2024

alexpensify closed this as completed Oct 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[$250] Task – App crashes when click on assignee in existing task #49514

[$250] Task – App crashes when click on assignee in existing task #49514

IuliiaHerets commented Sep 20, 2024 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Sep 20, 2024

melvin-bot bot commented Sep 20, 2024

github-actions bot commented Sep 20, 2024

huult commented Sep 20, 2024 •

edited

Loading

nkdengineer commented Sep 20, 2024

flodnv commented Sep 20, 2024

nkdengineer commented Sep 20, 2024

grgia commented Sep 20, 2024 •

edited

Loading

grgia commented Sep 20, 2024

rayane-djouah commented Sep 20, 2024

flodnv commented Sep 23, 2024

BrtqKr commented Sep 23, 2024

flodnv commented Sep 23, 2024

melvin-bot bot commented Sep 23, 2024

melvin-bot bot commented Sep 23, 2024

nkdengineer commented Sep 23, 2024

nkdengineer commented Sep 23, 2024

flodnv commented Sep 23, 2024

alexpensify commented Sep 23, 2024

isagoico commented Sep 23, 2024

alexpensify commented Sep 30, 2024

alexpensify commented Oct 2, 2024

jjcoffee commented Oct 3, 2024

luacmartins commented Oct 3, 2024

alexpensify commented Oct 4, 2024 •

edited

Loading

alexpensify commented Oct 4, 2024

jjcoffee commented Oct 7, 2024

nkdengineer commented Oct 7, 2024

alexpensify commented Oct 7, 2024

alexpensify commented Oct 8, 2024

nkdengineer commented Oct 9, 2024

jjcoffee commented Oct 9, 2024

alexpensify commented Oct 9, 2024

[$250] Task – App crashes when click on assignee in existing task #49514

[$250] Task – App crashes when click on assignee in existing task #49514

Comments

IuliiaHerets commented Sep 20, 2024 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Sep 20, 2024

melvin-bot bot commented Sep 20, 2024

github-actions bot commented Sep 20, 2024

huult commented Sep 20, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

nkdengineer commented Sep 20, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

flodnv commented Sep 20, 2024

nkdengineer commented Sep 20, 2024

grgia commented Sep 20, 2024 • edited Loading

grgia commented Sep 20, 2024

rayane-djouah commented Sep 20, 2024

flodnv commented Sep 23, 2024

BrtqKr commented Sep 23, 2024

flodnv commented Sep 23, 2024

melvin-bot bot commented Sep 23, 2024

melvin-bot bot commented Sep 23, 2024

nkdengineer commented Sep 23, 2024

nkdengineer commented Sep 23, 2024

flodnv commented Sep 23, 2024

alexpensify commented Sep 23, 2024

isagoico commented Sep 23, 2024

alexpensify commented Sep 30, 2024

alexpensify commented Oct 2, 2024

jjcoffee commented Oct 3, 2024

luacmartins commented Oct 3, 2024

alexpensify commented Oct 4, 2024 • edited Loading

alexpensify commented Oct 4, 2024

jjcoffee commented Oct 7, 2024

nkdengineer commented Oct 7, 2024

alexpensify commented Oct 7, 2024

alexpensify commented Oct 8, 2024

nkdengineer commented Oct 9, 2024

jjcoffee commented Oct 9, 2024

alexpensify commented Oct 9, 2024

IuliiaHerets commented Sep 20, 2024 •

edited by melvin-bot bot

Loading

huult commented Sep 20, 2024 •

edited

Loading

grgia commented Sep 20, 2024 •

edited

Loading

alexpensify commented Oct 4, 2024 •

edited

Loading